## Summary
This PR implements the tournament schedule tab functionality and fixes all remaining E2E test failures.
### Changes Included
1. **Tournament Schedule Feature**
- Added tournament schedule page at `/admin/tournaments/[id]/schedule`
- Implemented "Generate Schedule" button functionality
- Added schedule generation logic for round-robin tournaments
2. **E2E Test Fixes**
- Fixed database connection issues in production builds
- Improved test reliability with better error handling and debugging
- Updated test infrastructure to use environment variables instead of hardcoded values
3. **CI/CD Updates**
- Added E2E test job to PR workflow
- Configured tests to run against development database
- Moved database password to Gitea secrets
4. **Code Quality**
- Removed hardcoded passwords from codebase
- Improved Prisma client configuration
- Enhanced authentication and navigation components
### Test Results
All 16 E2E test scenarios are now passing:
- Authentication tests: ✅
- Registration tests: ✅
- Tournament schedule tests: ✅
- Player schedule tests: ✅
- Admin navigation tests: ✅
### Database Configuration
- Tests run against `euchre_camp_dev` database
- Production builds use environment variables for database configuration
- Database password stored in Gitea secrets as `DB_PASSWORD`
### CI Pipeline
The PR workflow now includes:
1. Unit tests
2. E2E tests (using production build)
3. Version bump analysis
E2E tests must pass before PR can be merged.
Reviewed-on: #27
Co-authored-by: David Gwilliam <dhgwilliam@gmail.com>
Co-committed-by: David Gwilliam <dhgwilliam@gmail.com>
- Add support files to require config for proper hook loading
- Remove database cleanup from hooks (browser-only testing)
- Fix World type issues in hooks
- Cucumber tests now run successfully
- Add wordmark-navigation.feature with 3 scenarios
- Add step definitions for clicking wordmark and page assertions
- Test unauthenticated, player, and admin navigation paths
- Install @cucumber/cucumber and cucumber-pretty dependencies
- Create Cucumber configuration with tsx loader for TypeScript support
- Add step definitions for common navigation, form interactions, and assertions
- Add authentication step definitions for login/logout flows
- Create feature files for user registration and authentication
- Support multiple auth contexts (player, tournament admin, club admin)
- Configure package.json scripts for running Cucumber tests
Key features:
- Gherkin syntax (Given/When/Then) for behavior-driven testing
- Browser-only interactions (no direct database access)
- Dev site testing (tests run against running dev server)
- Happy path focus for acceptance testing
- Integration with existing TypeScript project
- Remove acceptance-tests job from PR workflow to fix pipeline failures
- Update analyze-bump-type to depend only on unit-tests
- Add automatic dev deployment in release workflow that updates docker-compose.yml
- Update docker-compose.yml to use correct registry path (docker.notsosm.art/euchre-camp)
- Update generate-docker-compose.js to use correct registry configuration
- Set explicit min/max password length in Better Auth config (8-128 chars)
- Fix CSV upload tests to use multipart/form-data instead of data
- Add @chromium-admin annotations to tests requiring admin access
- Fix testDir path from './src/__tests__/e2e' to './e2e'
- Fix globalSetup path from './src/__tests__/e2e/global.setup' to './e2e/global.setup'
- Create .env.development.example with development database configuration
- Update .gitignore to allow .env.example files to be tracked
- Remove PostgreSQL service container configuration
- Use existing PostgreSQL server at dhg.lol with dev credentials
- Update DATABASE_URL to use euchre_camp:LINGO5row_hiding@dhg.lol:5432/euchre_camp_dev
- Apply environment variables to Prisma client generation and migration steps
- Add PostgreSQL service container to acceptance-tests job
- Update DATABASE_URL to use euchre_camp_dev:euchreCampDev
- Remove SQLite configuration which was incompatible with schema
- Simplify environment variable configuration in acceptance-tests
- Create Dockerfile.ci-base with Bun, Node.js, and Playwright pre-installed
- Add build-ci-images workflow that triggers on package.json changes
- Update PR workflow to use custom ci-base image instead of GitHub Actions
- Update Release workflow to use custom ci-base image
- Remove dependency on oven/setup-bun@v2 GitHub Action
- Remove dependency on docker/setup-buildx-action GitHub Action
- Images are automatically built when dependencies in package.json update
- Weekly scheduled rebuild ensures tools stay current
This resolves the 'authentication required: Repository not found' error
when Gitea Actions tries to clone GitHub Actions from external repositories.
Mock @prisma/client globally in bun-setup.ts to allow unit tests to run
without requiring the generated Prisma client. This improves test isolation
and allows tests to pass even when prisma generate hasn't been run.
The unit-tests job was failing because it couldn't find the generated Prisma client.
Added prisma generate step before running unit tests to ensure the client is available.
- Downgrade ESLint from v10.1.0 to v8.57.1
- Create .eslintrc.json config (ESLint v8 format)
- Remove eslint.config.js (flat config format)
- ESLint LSP (vscode-langservers-extracted) doesn't support ESLint v10+
The vscode-eslint-language-server from vscode-langservers-extracted v4.10.0
is not compatible with ESLint v10's Flat Config format. Downgrading to
ESLint v8 ensures the ESLint LSP in Neovim works correctly.
- Install @types/bun and @types/jsdom for proper type definitions
- Fix mock function typing in test files
- Create jest-dom.d.ts to properly extend Bun's Matchers interface
- Remove MockedFunction imports (not supported in Bun's types)
- Cast global.fetch and useSession mocks to any where needed
- Fix mock.module return types to match expected signatures
This resolves TypeScript errors that were preventing proper code
completion and type checking in IDEs.
- Created eslint.config.js using the new flat config format
- Removed .eslintrc.json (old format no longer supported in ESLint v9+)
- Maintained same configuration as before (next/core-web-vitals, next/typescript)
- Kept same ignore patterns
ESLint v10.x requires the new flat config format (eslint.config.js),
but the project uses the old .eslintrc.json format. Downgrading to
ESLint v8.x which supports the legacy configuration format.
The workflow was running 'bun test' without arguments, which caused
Bun to scan all directories including e2e/, picking up Playwright tests
that should only run in the acceptance-tests phase.
Updated to explicitly target unit/component tests:
- src/__tests__/unit/
- src/__tests__/*.test.tsx
- src/__tests__/auth-simple.test.ts
Replace mock.clearAllMocks() with mockFetch.mockClear() to only
clear the specific fetch mock without affecting global module mocks
used by other test files.
- Add explicit next/link mock for consistency
- Remove mock.clearAllMocks() from beforeEach/afterEach
- Navigation tests now rely on module mocks set at file level
- Prevents interference with other test files
Add afterEach hook to clear document.body.innerHTML between tests.
This prevents test pollution where elements from previous tests
interfere with subsequent test queries.
- Update all test files to use named mock variables instead of inline mocks
- Clear mock history in beforeEach instead of using mock.restore()
- Add default mock implementations stored at module level
- Document that tests should not use --randomize flag due to mock.module() limitations
- All 89 unit tests pass consistently without randomization
- Update Dockerfile to use oven/bun:alpine image
- Update PR workflow to use Bun (oven/setup-bun action)
- Update Test workflow to use Bun
- Update Release workflow to use Bun
- Remove test.yml workflow (redundant with PR workflow)
- Update Docker build commands to use Bun
- Docker build verified working
- Install Bun via mise
- Update package.json scripts to use Bun
- Migrate unit tests from Vitest to Bun test runner
- Migrate component tests from Vitest to Bun test runner
- Configure Bun with DOM environment for React Testing Library
- Keep Playwright for E2E tests (as planned)
- 93/100 tests passing (7 flaky tests when running all together, pass individually)
- Set output variable 'committed' in commit step
- Add conditional execution to all subsequent steps
- Only create tag, build Docker images, and deploy if commit was successful
- Add nested try-catch to handle git log failures
- Return empty array if all git attempts fail
- Add warning message when commit history cannot be retrieved
- Fixed bump-version.js to properly handle --yes flag in CI environments
- Added check to skip commit if no changes to package.json or CHANGELOG.md
- Ensured script exits cleanly after version bump with --yes flag
## Summary
This PR fixes the release workflow to properly handle version bumping on PR merge and uses the new Docker registry authentication secrets.
## Changes
### Release Workflow (release.yml)
- **Version Bumping**: Now automatically bumps version on PR merge
- Determines bump type from commit messages (major/minor/patch)
- Commits version bump to `package.json` and `CHANGELOG.md`
- Creates git tag for the release
- **Docker Registry Auth**: Uses `DOCKER_LOGIN` and `DOCKER_PASSWORD` secrets
- Falls back gracefully if secrets are not configured
- **Tag Handling**: Checks if tag exists before creating (prevents failures)
### PR Workflow (pr.yml) - NEW
- Runs unit tests on every PR
- Analyzes commits to suggest bump type
- Comments the suggested bump type on the PR
### Documentation
- Added `WORKFLOW_ARCHITECTURE.md` explaining the workflow design
## Workflow Architecture
**Two-step process:**
1. **PR Workflow** (on PR): Analyzes commits and suggests bump type
2. **Release Workflow** (on merge): Bumps version, creates tag, builds Docker image
## Benefits
1. **No CI Loops**: Version bump commits are detected and skipped
2. **Clear Communication**: PR comments inform developers of version impact
3. **Semantic Versioning**: Automated adherence to semver rules
4. **Traceability**: Git tags and changelog reflect all changes
## Testing
The new workflows will be tested when this PR is merged.
Closes#13 (Add database test safety configuration)
Reviewed-on: #17
Co-authored-by: David Gwilliam <dhgwilliam@gmail.com>
Co-committed-by: David Gwilliam <dhgwilliam@gmail.com>
Gitea Actions
david