feat: Implement tournament schedule tab and fix E2E tests #27

Merged

david merged 43 commits from feature/7-schedule-tab into main 2026-04-27 01:59:17 +00:00

Conversation 3 Commits 43 Files Changed 97

+7950 -1341

david commented 2026-04-26 23:39:44 +00:00

Owner

Copy Link

Copy Source

Summary

This PR implements the tournament schedule tab functionality and fixes all remaining E2E test failures.

Changes Included

1. Tournament Schedule Feature

   • Added tournament schedule page at /admin/tournaments/[id]/schedule
   • Implemented "Generate Schedule" button functionality
   • Added schedule generation logic for round-robin tournaments

2. E2E Test Fixes

   • Fixed database connection issues in production builds
   • Improved test reliability with better error handling and debugging
   • Updated test infrastructure to use environment variables instead of hardcoded values

3. CI/CD Updates

   • Added E2E test job to PR workflow
   • Configured tests to run against development database
   • Moved database password to Gitea secrets

4. Code Quality

   • Removed hardcoded passwords from codebase
   • Improved Prisma client configuration
   • Enhanced authentication and navigation components

Test Results

All 16 E2E test scenarios are now passing:

• Authentication tests: ✅
• Registration tests: ✅
• Tournament schedule tests: ✅
• Player schedule tests: ✅
• Admin navigation tests: ✅

Database Configuration

• Tests run against euchre_camp_dev database
• Production builds use environment variables for database configuration
• Database password stored in Gitea secrets as DB_PASSWORD

CI Pipeline

The PR workflow now includes:

1. Unit tests
2. E2E tests (using production build)
3. Version bump analysis

E2E tests must pass before PR can be merged.

## Summary This PR implements the tournament schedule tab functionality and fixes all remaining E2E test failures. ### Changes Included 1. **Tournament Schedule Feature** - Added tournament schedule page at `/admin/tournaments/[id]/schedule` - Implemented "Generate Schedule" button functionality - Added schedule generation logic for round-robin tournaments 2. **E2E Test Fixes** - Fixed database connection issues in production builds - Improved test reliability with better error handling and debugging - Updated test infrastructure to use environment variables instead of hardcoded values 3. **CI/CD Updates** - Added E2E test job to PR workflow - Configured tests to run against development database - Moved database password to Gitea secrets 4. **Code Quality** - Removed hardcoded passwords from codebase - Improved Prisma client configuration - Enhanced authentication and navigation components ### Test Results All 16 E2E test scenarios are now passing: - Authentication tests: ✅ - Registration tests: ✅ - Tournament schedule tests: ✅ - Player schedule tests: ✅ - Admin navigation tests: ✅ ### Database Configuration - Tests run against `euchre_camp_dev` database - Production builds use environment variables for database configuration - Database password stored in Gitea secrets as `DB_PASSWORD` ### CI Pipeline The PR workflow now includes: 1. Unit tests 2. E2E tests (using production build) 3. Version bump analysis E2E tests must pass before PR can be merged.

david added 41 commits 2026-04-26 23:44:57 +00:00

feat: add round-robin schedule generator ... 3e98c59d85

Implement circle-method algorithm for generating round-robin tournament
schedules. Handles both even and odd team counts with bye rounds.

Includes unit tests for algorithm correctness, input validation, and
expected round/matchup calculations.

feat: add schedule API endpoints ... df4d6fff7c

GET returns rounds with matchups for a tournament.
POST generates a round-robin schedule from registered teams.
DELETE removes all rounds and matchups.

All endpoints enforce tournament admin permissions via canManageTournament.

feat: add tournament schedule page with generator component ... 0b792cc911

Schedule page displays round-robin rounds with matchups, team names,
status badges, and links to result entry. Generator component provides
generate/delete buttons with success/error feedback.

feat: convert tournament tabs to functional navigation links ... 54f89c4bec

Replace non-functional tab buttons with Link components for Schedule
and Results tabs. Disable unimplemented tabs (Participants, Teams,
Analytics) as styled spans with cursor-not-allowed.

test: add acceptance tests for schedule tab ... 814dff2280

Playwright tests covering: schedule link visibility, empty state,
schedule generation, round/matchup display, and API response format.
Closes #7.

fix: use bun.lock instead of bun.lockb in Dockerfile ... 6547557ea4

Bun v1.2+ switched from binary lockfile (bun.lockb) to text-based
bun.lock format. Update the Dockerfile COPY to match.

feat: add team configuration fields to Event model ... 3beaa52335

Add fields for team durability, partner rotation, and configuration:
- teamDurability: permanent, variable, or per_round
- partnerRotation: none, minimize_repeat, maximize_even, elo_based
- allowByes: handle odd participant counts
- teamConfiguration: JSON for additional options
- maxRosterChanges: limit roster changes per player
- requireAdminVerify: for match score verification

Refs #22

feat: add team generator library with multiple strategies ... c141fc6dd7

Implement team generation algorithms for tournament partnerships:
- Random pairing (Fisher-Yates shuffle)
- ELO-based pairing (strongest + weakest)
- Even matches (balance competitive levels)
- Minimize repeat partnerships
- Support for byes with odd participant counts
- Team balance calculation utilities

Refs #22

feat: add team generation API endpoints ... 912a1cd268

Add API endpoints for team management:
- POST /api/tournaments/[id]/teams/generate: Generate teams based on configuration
- DELETE /api/tournaments/[id]/teams: Delete all teams
- GET /api/tournaments/[id]/teams: Fetch teams and configuration

Supports multiple generation strategies:
- Random pairing
- ELO-based pairing
- Even matches
- Minimize repeat partnerships

Refs #22

feat: add TeamsSection component for team configuration UI ... 0ee295e9b1

Add interactive team configuration panel:
- Team durability selection (permanent, variable, per_round)
- Partner rotation strategy selection
- Allow byes configuration
- Generate Teams button with participant count
- Delete All Teams functionality
- Available participants display with ELO ratings

Refs #22

feat: integrate TeamsSection component into tournament detail page ... 1532c10223

Update tournament detail page to use new TeamsSection component:
- Import TeamsSection component
- Replace static teams display with interactive configuration
- Pass tournament ID, teams, and participants to component

Refs #22

test: add unit tests for team generation algorithms ... ec798fc29d

Add comprehensive tests for team generation:
- Test random pairing strategy
- Test ELO-based pairing strategy
- Test even matches strategy
- Test minimize repeat partnerships
- Test bye player handling
- Test team balance calculation
- Test partnership frequency tracking

All 19 tests pass.

Refs #22

fix: check response.ok before parsing JSON in fetch calls ... 5763534e26

Fix JSON parsing errors when server returns non-JSON responses:
- Check response.ok before calling response.json()
- Add fallback error messages using status text
- Apply fix to all fetch calls across 12 components

This prevents 'JSON.parse: unexpected character' errors when
server returns HTML error pages or other non-JSON responses.

fix: make player search case-insensitive ... 729993913a

Add 'mode: insensitive' to Prisma query for player search:
- Allows searching by partial name regardless of case
- Improves user experience when searching for players

feat: add tournament type and team support to tournament APIs ... e086d7398a

Update tournament APIs to support:
- tournamentType field (individual/team)
- Team creation for team tournaments
- Even number validation for team tournaments
- Automatic pairing of consecutive players into teams

feat: add tournamentType field to Event model ... 1d830ee8a3

Add tournamentType field with default value 'individual':
- Supports 'individual' and 'team' tournament types
- Creates migration for database schema update

chore: add .env.development to gitignore 7d33947619

fix: support partial updates in tournament PUT endpoint ... ade3b82e3c

- Change PUT endpoint to only include fields present in the request
- Add support for team configuration fields (teamDurability, partnerRotation, allowByes)
- Fix contradictory test that expected resetting allowTies when not provided
- When a field is not in the request, it is preserved (not modified)

Fixes issue where Save Configuration button would fail with
'Tournament name is required' error.

chore: add .env.dev to gitignore 903654466b

refactor(db): remove Team model and add player fields to BracketMatchup aff0ed70e4

refactor(schema): update Match model to use player fields instead of team fields 420a9ff645

refactor(lib): update schedule and team generators to use player pairings 118b6ea840

refactor(lib): update rating utilities to use new player field names a1329f077f

refactor(api): update all API routes to use new player field names c00f26919b

refactor(ui): update components to use new player field names 52da77d57b

refactor(tests): update test files to use new player field names 9137fabc2b

refactor(tests): update remaining test files for ephemeral team model eeb0f7970a

feat: implement variable team matchups with partner rotation ... 62ac6d1b79

- Add manual team entry for permanent teams in Matchups tab
- Rename 'Teams' tab to 'Matchups' for clarity
- Implement partner rotation strategies (minimize_repeat, maximize_even, elo_based)
- Track partnerships across rounds to minimize repeat pairings
- Fix unit tests for team configuration and ELO calculations
- Add E2E test for 9+ participant tournaments with variable matchups

Key changes:
- TeamsSection.tsx: Added router.refresh(), manual team entry, and matchup display
- schedule-generator.ts: Enhanced generateVariableRoundRobin to track partnerships
- team-generator.ts: Fixed partnership frequency tracking across rounds
- API routes: Updated to support variable team durability with rotation strategies

fix: update AdminMatchesPage to use correct player property names (player1P1, player1P2, etc.) a06cda96f2

fix: update Match interface in entry page to use correct player property names 2546de0cec

fix: add database safety check to Cucumber hooks ... c18cf29452

- Prevents tests from running against production database
- Uses same logic as Playwright global setup
- Ensures test data isolation

fix: add browser relaunch logic to Cucumber hooks ... 9fbdc5e51f

- Add error handling for browser context creation
- Auto-relaunch browser if context creation fails
- Add better error logging

fix: update registration redirect and wordmark navigation ... 1d6e15c0ab

- Simplify registration redirect after session refresh
- Update wordmark to use dynamic href based on session/role
- Add anchor tag for wordmark to avoid Next.js Link issues

test: update Cucumber configuration and support files 2ae1ec6a58

test: update Cucumber step definitions for better error handling and debugging 2b38fbb0f2

ci: add E2E test job to PR workflow and update test scripts 8664d330bc

fix: update Prisma client configuration and cleanup script d69bd7a0ba

fix: update authentication and navigation components d436b1f66e

test: update test files and documentation 9589bb8718

chore: add new route pages and environment configuration 6cfd5d325a

chore: remove .env.production from repository and add to .gitignore 2658dc07cb

david force-pushed feature/7-schedule-tab from b2fcf0fae7 to 2658dc07cb 2026-04-26 23:44:57 +00:00 Compare

gitea-actions bot commented 2026-04-27 00:03:38 +00:00

Copy Link

Copy Source

🏷️ Version Bump Analysis

Suggested bump type: PATCH
Reason: Defaulting to patch (fixes or other changes)

This PR will bump the version to the next patch version when merged.

## 🏷️ Version Bump Analysis **Suggested bump type:** `PATCH` **Reason:** Defaulting to patch (fixes or other changes) This PR will bump the version to the next patch version when merged.

gitea-actions bot commented 2026-04-27 00:09:44 +00:00

Copy Link

Copy Source

🏷️ Version Bump Analysis

Suggested bump type: PATCH
Reason: Defaulting to patch (fixes or other changes)

This PR will bump the version to the next patch version when merged.

## 🏷️ Version Bump Analysis **Suggested bump type:** `PATCH` **Reason:** Defaulting to patch (fixes or other changes) This PR will bump the version to the next patch version when merged.

david added 1 commit 2026-04-27 00:18:01 +00:00

feat: implement club admin dashboard with activity feed and settings 31fc26478d

gitea-actions bot commented 2026-04-27 00:22:25 +00:00

Copy Link

Copy Source

🏷️ Version Bump Analysis

Suggested bump type: PATCH
Reason: Defaulting to patch (fixes or other changes)

This PR will bump the version to the next patch version when merged.

## 🏷️ Version Bump Analysis **Suggested bump type:** `PATCH` **Reason:** Defaulting to patch (fixes or other changes) This PR will bump the version to the next patch version when merged.

david added 1 commit 2026-04-27 01:01:56 +00:00

fix: improve test script to ensure server is ready and properly cleaned up 07397974d0

david merged commit bb6be245b7 into main 2026-04-27 01:59:17 +00:00

david deleted branch feature/7-schedule-tab 2026-04-27 01:59:17 +00:00

david referenced this issue from a commit 2026-04-27 01:59:18 +00:00

feat: Implement tournament schedule tab and fix E2E tests (#27)

david referenced this pull request 2026-04-27 02:05:37 +00:00

As a club admin, I want a dashboard with club-wide statistics #11

david referenced this pull request 2026-04-27 02:06:01 +00:00

As a tournament admin, I want a Schedule tab to view round matchups #7

david referenced this pull request 2026-04-27 02:56:39 +00:00

As a user, clicking the EuchreCamp wordmark when logged in should take me to my homepage #24

david referenced this pull request 2026-04-27 02:56:49 +00:00

As a tournament admin, I want to configure team creation options for round robin tournaments #22

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

epic:admin-dashboard

Admin dashboard features

epic:authentication

Authentication and authorization

epic:player-features

Player-facing features

epic:tournament-management

Tournament management features

feature

New functionality

priority:high

High priority issue

ui

User interface changes

visualization

Data visualization

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

sara david

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: david/euchre_camp#27