david/euchre_camp
Public Access
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects 1 Releases 1 Wiki Activity

fix: version bumping and Docker registry authentication #17

Merged
david merged 17 commits from fix/workflow-tag-exists into main 2026-04-01 05:03:16 +00:00
Conversation 2 Commits 17 Files Changed 20
+884 -303
david commented 2026-04-01 03:02:18 +00:00
Owner
Copy Link
Copy Source

Summary

This PR fixes the release workflow to properly handle version bumping on PR merge and uses the new Docker registry authentication secrets.

Changes

Release Workflow (release.yml)

  • Version Bumping: Now automatically bumps version on PR merge
    • Determines bump type from commit messages (major/minor/patch)
    • Commits version bump to package.json and CHANGELOG.md
    • Creates git tag for the release
  • Docker Registry Auth: Uses DOCKER_LOGIN and DOCKER_PASSWORD secrets
    • Falls back gracefully if secrets are not configured
  • Tag Handling: Checks if tag exists before creating (prevents failures)

PR Workflow (pr.yml) - NEW

  • Runs unit tests on every PR
  • Analyzes commits to suggest bump type
  • Comments the suggested bump type on the PR

Documentation

  • Added WORKFLOW_ARCHITECTURE.md explaining the workflow design

Workflow Architecture

Two-step process:

  1. PR Workflow (on PR): Analyzes commits and suggests bump type
  2. Release Workflow (on merge): Bumps version, creates tag, builds Docker image

Benefits

  1. No CI Loops: Version bump commits are detected and skipped
  2. Clear Communication: PR comments inform developers of version impact
  3. Semantic Versioning: Automated adherence to semver rules
  4. Traceability: Git tags and changelog reflect all changes

Testing

The new workflows will be tested when this PR is merged.

Closes #13 (Add database test safety configuration)

## Summary This PR fixes the release workflow to properly handle version bumping on PR merge and uses the new Docker registry authentication secrets. ## Changes ### Release Workflow (release.yml) - **Version Bumping**: Now automatically bumps version on PR merge - Determines bump type from commit messages (major/minor/patch) - Commits version bump to `package.json` and `CHANGELOG.md` - Creates git tag for the release - **Docker Registry Auth**: Uses `DOCKER_LOGIN` and `DOCKER_PASSWORD` secrets - Falls back gracefully if secrets are not configured - **Tag Handling**: Checks if tag exists before creating (prevents failures) ### PR Workflow (pr.yml) - NEW - Runs unit tests on every PR - Analyzes commits to suggest bump type - Comments the suggested bump type on the PR ### Documentation - Added `WORKFLOW_ARCHITECTURE.md` explaining the workflow design ## Workflow Architecture **Two-step process:** 1. **PR Workflow** (on PR): Analyzes commits and suggests bump type 2. **Release Workflow** (on merge): Bumps version, creates tag, builds Docker image ## Benefits 1. **No CI Loops**: Version bump commits are detected and skipped 2. **Clear Communication**: PR comments inform developers of version impact 3. **Semantic Versioning**: Automated adherence to semver rules 4. **Traceability**: Git tags and changelog reflect all changes ## Testing The new workflows will be tested when this PR is merged. Closes #13 (Add database test safety configuration)
david added 3 commits 2026-04-01 03:02:19 +00:00
fix: handle existing git tags and use DOCKER_LOGIN/DOCKER_PASSWORD secrets c9cd00a055
fix: update release workflow to bump version on PR merge 73ba929e36
feat: add PR workflow with bump type analysis
Test / unit-tests (push) Has been cancelled
Details
Test / safe-acceptance-tests (push) Has been cancelled
Details
Test / unit-tests (pull_request) Failing after 11m39s
Details
Pull Request / unit-tests (pull_request) Failing after 16m27s
Details
Pull Request / analyze-bump-type (pull_request) Has been cancelled
Details
Test / safe-acceptance-tests (pull_request) Has been cancelled
Details
5c9b98a926
david added 1 commit 2026-04-01 03:02:41 +00:00
docs: add workflow architecture documentation
Test / unit-tests (push) Has been cancelled
Details
Test / safe-acceptance-tests (push) Has been cancelled
Details
Pull Request / unit-tests (pull_request) Successful in 13m14s
Details
Test / unit-tests (pull_request) Successful in 13m11s
Details
Pull Request / analyze-bump-type (pull_request) Successful in 10s
Details
Test / safe-acceptance-tests (pull_request) Has been cancelled
Details
9b69cb84e3
david added 1 commit 2026-04-01 03:05:56 +00:00
fix: optimize workflows to avoid redundant test runs
Pull Request / analyze-bump-type (pull_request) Successful in 21s
Details
Test / unit-tests (push) Has been cancelled
Details
ff7461973a
gitea-actions bot commented 2026-04-01 04:48:30 +00:00
Copy Link
Copy Source

🏷️ Version Bump Analysis

Suggested bump type: PATCH
Reason: Defaulting to patch (fixes or other changes)

This PR will bump the version to the next patch version when merged.

## 🏷️ Version Bump Analysis **Suggested bump type:** `PATCH` **Reason:** Defaulting to patch (fixes or other changes) This PR will bump the version to the next patch version when merged.
gitea-actions bot commented 2026-04-01 04:48:41 +00:00
Copy Link
Copy Source

🏷️ Version Bump Analysis

Suggested bump type: PATCH
Reason: Defaulting to patch (fixes or other changes)

This PR will bump the version to the next patch version when merged.

## 🏷️ Version Bump Analysis **Suggested bump type:** `PATCH` **Reason:** Defaulting to patch (fixes or other changes) This PR will bump the version to the next patch version when merged.
david added 9 commits 2026-04-01 04:51:56 +00:00
ci: add unit and acceptance tests to PR workflow with SQLite 6b70c3f388
feat: support both SQLite and PostgreSQL in prisma.ts 9980021037
chore: update justfile with SQLite acceptance tests and utility tasks e08d72bfe6
docs: update README and AGENTS.md with CI/CD and justfile info 5f02726ba6
docs: add FILE_ORGANIZATION.md to document project structure 0e1046fcb5
refactor: move deployment docs to docs/deployment/ directory 9511eed477
refactor: move Python scripts to scripts/python/ directory 039b927bb7
refactor: move TODO.md to docs directory for better organization 80714a5daa
refactor: move legacy files to organized directories
Test / unit-tests (push) Failing after 6m1s
Details
Pull Request / acceptance-tests (pull_request) Has been cancelled
Details
Pull Request / analyze-bump-type (pull_request) Has been cancelled
Details
Pull Request / unit-tests (pull_request) Has been cancelled
Details
00373fcef4
david added 3 commits 2026-04-01 04:59:41 +00:00
ci: use node:20-alpine container to avoid Node.js setup time 5b91cf1426
chore: add script for running tests in Docker container 9c884ee020
chore: update justfile with container testing note
Test / unit-tests (push) Successful in 2m39s
Details
Pull Request / unit-tests (pull_request) Successful in 2m40s
Details
Pull Request / acceptance-tests (pull_request) Failing after 1m56s
Details
Pull Request / analyze-bump-type (pull_request) Has been skipped
Details
fa6c4369a6
david merged commit 501e1b7e23 into main 2026-04-01 05:03:16 +00:00
david deleted branch fix/workflow-tag-exists 2026-04-01 05:03:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 epic:admin-dashboard
Admin dashboard features
 epic:authentication
Authentication and authorization
 epic:player-features
Player-facing features
 epic:tournament-management
Tournament management features
 feature
New functionality
 priority:high
High priority issue
 ui
User interface changes
 visualization
Data visualization
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sara david
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: david/euchre_camp#17
Delete Branch "fix/workflow-tag-exists"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?