ci-image-improvements #18

Merged

david merged 12 commits from ci-image-improvements into main 2026-04-01 06:14:26 +00:00

Conversation 0 Commits 12 Files Changed 5

+54 -17

david commented 2026-04-01 05:21:31 +00:00

Owner

Copy Link

Copy Source

No description provided.

david added 4 commits 2026-04-01 05:21:32 +00:00

ci: add CI image builder workflow and Dockerfile dfd66cde0b

chore: add script for building CI image locally b686c3673e

docs: update documentation with CI image info 941d857feb

fix: use correct docker registry and image name 3983049d2c

david added 1 commit 2026-04-01 05:52:08 +00:00

fix: update workflows to checkout in /app directory 4c2687498f

david added 1 commit 2026-04-01 05:53:46 +00:00

fix: use symlinks to link node_modules from container c611c68822

david added 1 commit 2026-04-01 05:59:40 +00:00

fix: move node_modules to /workspace in CI image and update symlink ba180ae6e1

david added 2 commits 2026-04-01 06:01:59 +00:00

fix: use NODE_PATH env var instead of symlinks 81c93bafc1

chore: revert Dockerfile back to /app directory b445d9044a

david added 1 commit 2026-04-01 06:03:06 +00:00

fix: add /app/node_modules to PATH and NODE_PATH 4116884f9f

david added 1 commit 2026-04-01 06:04:30 +00:00

fix: symlink from /app/node_modules to workspace 397594a9df

david added 1 commit 2026-04-01 06:11:11 +00:00

refactor: revert CI image approach and use standard npm ci in workflows ... d24e810ad1

The CI image approach with pre-installed dependencies doesn't work with Gitea Actions due to workspace mounting issues. When Gitea Actions runs a container job, it mounts the workspace at a specific path (e.g., /workspace/david/euchre_camp), which hides the container's /app directory where dependencies were installed.

Changes:
- Reverted pr.yml unit-tests to use node:20-alpine with npm ci
- Updated pr.yml acceptance-tests to use mcr.microsoft.com/playwright image with npm ci
- Updated test.yml to use node:20-alpine with npm ci
- Removed ci-image-builder.yml workflow
- Removed Dockerfile.ci and build-ci-image.sh
- Updated AGENTS.md and README.md to document the deprecation
- Updated justfile to remove CI image commands

The standard approach of running npm ci in each workflow is the recommended approach for Gitea Actions.

david merged commit 6b9b690947 into main 2026-04-01 06:14:26 +00:00

david deleted branch ci-image-improvements 2026-04-01 06:14:26 +00:00

david referenced this issue from a commit 2026-04-01 06:14:26 +00:00

ci-image-improvements (#18)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

epic:admin-dashboard

Admin dashboard features

epic:authentication

Authentication and authorization

epic:player-features

Player-facing features

epic:tournament-management

Tournament management features

feature

New functionality

priority:high

High priority issue

ui

User interface changes

visualization

Data visualization

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

sara david

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: david/euchre_camp#18