Commit Graph

206 Commits

Author SHA1 Message Date
018778dd11 feat(adapters): Export MessageOverlayStage and MessageOverlayConfig
- Add MessageOverlayStage and MessageOverlayConfig to adapter exports
- Make message overlay stage available for pipeline construction
2026-03-21 15:31:54 -07:00
4acd7b3344 feat(pipeline): Integrate MessageOverlayStage into pipeline construction
- Import MessageOverlayStage in pipeline_runner.py
- Add message overlay stage when preset.enable_message_overlay is True
- Add overlay stage in both initial construction and preset change handler
- Use config.NTFY_TOPIC and config.MESSAGE_DISPLAY_SECS for configuration
2026-03-21 15:31:49 -07:00
2976839f7b feat(preset): Add enable_message_overlay to presets
- Add enable_message_overlay field to PipelinePreset dataclass
- Enable message overlay in demo, ui, and firehose presets
- Add test-message-overlay preset for testing
- Update preset loader to support new field from TOML files
2026-03-21 15:31:43 -07:00
ead4cc3d5a feat(theme): Add theme system with ACTIVE_THEME support
- Add Theme class and THEME_REGISTRY to engine/themes.py
- Add set_active_theme() function to config.py
- Add msg_gradient() function to use theme-based message gradients
- Support --theme CLI flag to select theme (green, orange, purple)
- Initialize theme on module load with fallback to default
2026-03-21 15:31:35 -07:00
1010f5868e fix(pipeline): Update DisplayStage to depend on camera capability
- Add camera dependency to ensure camera transformation happens before display
- Ensures buffer is fully transformed before being shown on display
2026-03-21 15:31:28 -07:00
fff87382f6 fix(pipeline): Update CameraStage to depend on camera.state
- Add camera.state dependency to ensure CameraClockStage runs before CameraStage
- Fixes pipeline execution order: source -> camera_update -> render -> camera -> message_overlay -> display
- Ensures camera transformation is applied before message overlay
2026-03-21 15:31:23 -07:00
b3ac72884d feat(message-overlay): Add MessageOverlayStage for pipeline integration
- Create MessageOverlayStage adapter for ntfy message overlay
- Integrates NtfyPoller with pipeline architecture
- Uses centered panel with pink/magenta gradient for messages
- Provides message.overlay capability
2026-03-21 15:31:17 -07:00
7c26150408 test: add comprehensive unit tests for core components
- tests/test_canvas.py: 33 tests for Canvas (2D rendering surface)
- tests/test_firehose.py: 5 tests for FirehoseEffect
- tests/test_pipeline_order.py: 3 tests for execution order verification
- tests/test_renderer.py: 22 tests for ANSI parsing and PIL rendering

These tests provide solid coverage for foundational modules.
2026-03-21 13:18:08 -07:00
7185005f9b feat(figment): complete pipeline integration with native effect plugin
- Add engine/effects/plugins/figment.py (native pipeline implementation)
- Add engine/figment_render.py, engine/figment_trigger.py, engine/themes.py
- Add 3 SVG assets in figments/ (Mexican/Aztec motif)
- Add engine/display/backends/animation_report.py for debugging
- Add engine/pipeline/adapters/frame_capture.py for frame capture
- Add test-figment preset to presets.toml
- Add cairosvg optional dependency to pyproject.toml
- Update EffectPluginStage to support is_overlay attribute (for overlay effects)
- Add comprehensive tests: test_figment_effect.py, test_figment_pipeline.py, test_figment_render.py
- Remove obsolete test_ui_simple.py
- Update TODO.md with test cleanup plan
- Refactor test_adapters.py to use real components instead of mocks

This completes the figment SVG overlay feature integration using the modern pipeline architecture, avoiding legacy effects_plugins. All tests pass (758 total).
2026-03-21 13:09:37 -07:00
ef0c43266a doc(skills): Update mainline-display skill 2026-03-20 03:40:22 -07:00
e02ab92dad feat(tests): Add acceptance tests and HTML report generator 2026-03-20 03:40:20 -07:00
4816ee6da8 fix(main): Add render stage for non-headline sources 2026-03-20 03:40:15 -07:00
ec9f5bbe1f fix(terminal): Handle BorderMode.OFF enum correctly 2026-03-20 03:40:12 -07:00
f64590c0a3 fix(hud): Correct overlay logic and context mismatch 2026-03-20 03:40:09 -07:00
b2404068dd docs: Add ADR for preset scripting language (Issue #48) 2026-03-20 03:39:33 -07:00
677e5c66a9 chore: Add test-reports to gitignore 2026-03-20 03:39:23 -07:00
ad8513f2f6 fix(tests): Correctly patch fetch functions in test_app.py
- Patch  instead of
- Add missing patches for  and  in background threads
- Prevent network I/O during tests
2026-03-19 23:20:32 -07:00
7eaa441574 feat: Add fast startup fetch and background caching
- Add  for quick startup using first N feeds
- Add background thread for full fetch and caching
- Update  to use fast fetch
- Update docs and skills
2026-03-19 22:38:55 -07:00
4f2cf49a80 fix lint: combine with statements 2026-03-19 22:36:35 -07:00
ff08b1d6f5 feat: Complete Pipeline Mutation API implementation
- Add can_hot_swap() function to Pipeline class
- Add cleanup_stage() method to Pipeline class
- Fix remove_stage() to rebuild execution order after removal
- Extend ui_panel.execute_command() with docstrings for mutation commands
- Update WebSocket handler to support pipeline mutation commands
- Add _handle_pipeline_mutation() function for command routing
- Add comprehensive integration tests in test_pipeline_mutation_commands.py
- Update AGENTS.md with mutation API documentation

Issue: #35 (Pipeline Mutation API)
Acceptance criteria met:
-  can_hot_swap() checker for stage compatibility
-  cleanup_stage() cleans up specific stages
-  remove_stage_safe() rebuilds execution order (via remove_stage)
-  Unit tests for all operations
-  Integration with WebSocket commands
-  Documentation in AGENTS.md
2026-03-19 04:33:00 -07:00
cd5034ce78 feat: Add oscilloscope with image data source integration
- demo_image_oscilloscope.py: Uses ImageDataSource pattern to generate oscilloscope images
- Pygame renders waveforms to RGB surfaces
- PIL converts to 8-bit grayscale with RGBA transparency
- ANSI rendering converts grayscale to character ramp
- Features LFO modulation chain

Usage:
  uv run python scripts/demo_image_oscilloscope.py --lfo --modulate

Pattern:
  Pygame surface → PIL Image (L mode) → ANSI characters

Related to #46
2026-03-19 04:16:16 -07:00
161bb522be feat: Add oscilloscope with pipeline switching (text ↔ pygame)
- demo_oscilloscope_pipeline.py: Switches between text mode and Pygame+PIL mode
- 15 FPS frame rate for smooth viewing
- Mode switches every 15 seconds automatically
- Pygame renderer with waveform visualization
- PIL converts Pygame output to ANSI for terminal display
- Uses fonts/Pixel_Sparta.otf for font rendering

Usage:
  uv run python scripts/demo_oscilloscope_pipeline.py --lfo --modulate

Pipeline:
  Text Mode (15s) → Pygame+PIL to ANSI (15s) → Repeat

Related to #46
2026-03-19 04:11:53 -07:00
3fa9eabe36 feat: Add enhanced oscilloscope with LFO modulation chain
- demo_oscilloscope_mod.py: 15 FPS for smooth human viewing
- Uses cursor positioning instead of full clear to reduce flicker
- ModulatedOscillator class for LFO modulation chain
- Shows both modulator and modulated waveforms
- Supports modulation depth and frequency control

Usage:
  # Simple LFO (slow, smooth)
  uv run python scripts/demo_oscilloscope_mod.py --lfo

  # LFO modulation chain: modulator modulates main oscillator
  uv run python scripts/demo_oscilloscope_mod.py --modulate --lfo --mod-depth 0.3

  # Square wave modulation
  uv run python scripts/demo_oscilloscope_mod.py --modulate --lfo --mod-waveform square

Related to #46
2026-03-19 04:05:38 -07:00
31ac728737 feat: Add LFO mode options to oscilloscope demo
- Add --lfo flag for slow modulation (0.5Hz)
- Add --fast-lfo flag for rhythmic modulation (5Hz)
- Display frequency type (LFO/Audio) in output
- More intuitive LFO usage for modulation applications

Usage:
  uv run python scripts/demo_oscilloscope.py --lfo --waveform sine
  uv run python scripts/demo_oscilloscope.py --fast-lfo --waveform triangle
2026-03-19 04:02:06 -07:00
d73d1c65bd feat: Add oscilloscope-style waveform visualization
- demo_oscilloscope.py: Real-time oscilloscope display with continuous trace
- Shows waveform scrolling across the screen at correct time rate
- Supports all waveforms: sine, square, sawtooth, triangle, noise
- Frequency-based scrolling speed
- Single continuous trace instead of multiple copies

Related to #46
2026-03-19 03:59:41 -07:00
5d9efdcb89 fix: Remove duplicate argument definitions in demo_oscillator_simple.py
- Cleaned up argparse setup to remove duplicate --frequency and --frames arguments
- Ensures script runs correctly with all options

Related to #46
2026-03-19 03:50:05 -07:00
f2b4226173 feat: Add oscillator sensor visualization and data export scripts
- demo_oscillator_simple.py: Visualizes oscillator waveforms in terminal
- oscillator_data_export.py: Exports oscillator data as JSON
- Supports all waveforms: sine, square, sawtooth, triangle, noise
- Real-time visualization with phase tracking
- Configurable frequency, sample rate, and duration
2026-03-19 03:47:51 -07:00
238bac1bb2 feat: Complete pipeline hot-rebuild implementation with acceptance tests
- Implements pipeline hot-rebuild with state preservation (issue #43)
- Adds auto-injection of MVP stages for missing capabilities
- Adds radial camera mode for polar coordinate scanning
- Adds afterimage and motionblur effects using framebuffer history
- Adds comprehensive acceptance tests for camera modes and pipeline rebuild
- Updates presets.toml with new effect configurations

Related to: #35 (Pipeline Mutation API epic)
Closes: #43, #44, #45
2026-03-19 03:34:06 -07:00
0eb5f1d5ff feat: Implement pipeline hot-rebuild and camera improvements
- Fixes issue #45: Add state property to EffectContext for motionblur/afterimage effects
- Fixes issue #44: Reset camera bounce direction state in reset() method
- Fixes issue #43: Implement pipeline hot-rebuild with state preservation
- Adds radial camera mode for polar coordinate scanning
- Adds afterimage and motionblur effects
- Adds acceptance tests for camera and pipeline rebuild

Closes #43, #44, #45
2026-03-19 03:33:48 -07:00
14d622f0d6 Implement pipeline hot-rebuild with state preservation
- Add save_state/restore_state methods to CameraStage
- Add save_state/restore_state methods to DisplayStage
- Extend Pipeline._copy_stage_state() to preserve camera/display state
- Add save_state/restore_state methods to UIPanel for UI state preservation
- Update pipeline_runner to preserve UI state across preset changes

Camera state preserved:
- Position (x, y)
- Mode (feed, scroll, horizontal, etc.)
- Speed, zoom, canvas dimensions
- Internal timing state

Display state preserved:
- Initialization status
- Dimensions
- Reuse flag for display reinitialization

UI Panel state preserved:
- Stage enabled/disabled status
- Parameter values
- Selected stage and focused parameter
- Scroll position

This enables manual/event-driven rebuilds when inlet-outlet connections change,
while preserving all relevant state across pipeline mutations.
2026-03-18 23:30:24 -07:00
e684666774 Update TODO.md with Gitea issue references and sync task status 2026-03-18 23:19:00 -07:00
bb0f1b85bf Update docs, fix Pygame window, and improve camera stage timing 2026-03-18 23:16:09 -07:00
c57617bb3d fix(performance): use simple height estimation instead of PIL rendering
- Replace estimate_block_height (PIL-based) with estimate_simple_height (word wrap)
- Update viewport filter tests to match new height-based filtering (~4 items vs 24)
- Fix CI task duplication in mise.toml (remove redundant depends)

Closes #38
Closes #36
2026-03-18 22:33:36 -07:00
abe49ba7d7 fix(pygame): add fallback border rendering for fonts without box-drawing chars
- Detect if font lacks box-drawing glyphs by testing rendering
- Use pygame.graphics to draw border when text glyphs unavailable
- Adjust content offset to avoid overlapping border
- Ensures border always visible regardless of font support

This improves compatibility across platforms and font configurations.
2026-03-18 12:20:55 -07:00
6d2c5ba304 chore(display): add debug logging to NullDisplay for development
- Print first few frames periodically to aid debugging
- Remove obsolete design doc

This helps inspect buffer contents when running headless tests.
2026-03-18 12:19:34 -07:00
a95b24a246 feat(effects): add entropy parameter to effect plugins
- Add entropy field to EffectConfig (0.0 = calm, 1.0 = chaotic)
- Provide compute_entropy() method in EffectContext for dynamic scoring
- Update Fade, Firehose, Glitch, Noise plugin defaults with entropy values
- Enables finer control: intensity (strength) vs entropy (randomness)

This separates deterministic effect strength from probabilistic chaos, allowing more expressive control in UI panel and presets.

Fixes #32
2026-03-18 12:19:26 -07:00
cdcdb7b172 feat(app): add direct CLI mode, validation framework, fixtures, and UI panel integration
- Add run_pipeline_mode_direct() for constructing pipelines from CLI flags
- Add engine/pipeline/validation.py with validate_pipeline_config() and MVP rules
- Add fixtures system: engine/fixtures/headlines.json for cached test data
- Enhance fetch.py to use fixtures cache path
- Support fixture source in run_pipeline_mode()
- Add --pipeline-* CLI flags: source, effects, camera, display, UI, border
- Integrate UIPanel: raw mode, preset picker, event callbacks, param adjustment
- Add UI_PRESET support in app and hot-rebuild pipeline on preset change
- Add test UIPanel rendering and interaction tests

This provides a flexible pipeline construction interface with validation and interactive control.

Fixes #29, #30, #31
2026-03-18 12:19:18 -07:00
21fb210c6e feat(pipeline): integrate BorderMode and add UI preset
- params.py: border field now accepts bool | BorderMode
- presets.py: add UI_PRESET with BorderMode.UI, remove SIXEL_PRESET
- __init__.py: export UI_PRESET, drop SIXEL_PRESET
- registry.py: auto-register FrameBufferStage on discovery
- New FrameBufferStage for frame history and intensity maps
- Tests: update test_pipeline for UI preset, add test_framebuffer_stage.py

This sets the foundation for interactive UI panel and modern pipeline composition.
2026-03-18 12:19:10 -07:00
36afbacb6b refactor(display)!: remove deprecated backends, simplify protocol, and add BorderMode/UI rendering
- Remove SixelDisplay and KittyDisplay backends (unmaintained)
- Simplify Display protocol: reduce docstring noise, emphasize duck typing
- Add BorderMode enum (OFF, SIMPLE, UI) for flexible border rendering
- Rename render_border to _render_simple_border
- Add render_ui_panel() to compose main viewport with right-side UI panel
- Add new render_border() dispatcher supporting BorderMode
- Update __all__ to expose BorderMode, render_ui_panel, PygameDisplay
- Clean up DisplayRegistry: remove deprecated method docstrings
- Update tests: remove SixelDisplay import, assert sixel not in registry
- Add TODO comment to WebSocket backend about streaming improvements

This is a breaking change (removal of backends) but enables cleaner architecture and interactive UI panel.

Closes #13, #21
2026-03-18 12:18:02 -07:00
60ae4f7dfb feat(pygame): add glyph caching for performance improvement
- Add _glyph_cache dict to PygameDisplay.__init__
- Cache font.render() results per (char, fg, bg) combination
- Use blits() for batch rendering instead of individual blit calls
- Add TestRenderBorder tests (8 new tests) for border rendering
- Update NullDisplay.show() to support border=True for consistency
- Add test_show_with_border_uses_render_border for TerminalDisplay

Closes #28
2026-03-18 04:23:58 -07:00
4b26c947e8 chore: fix linting issues in plugins after refactor
- Remove unused imports in glitch.py
- Remove unused variables in hud.py
2026-03-18 04:07:17 -07:00
b37b2ccc73 refactor: move effects_plugins to engine/effects/plugins
- Move effects_plugins/ to engine/effects/plugins/
- Update imports in engine/app.py
- Update imports in all test files
- Follows capability-based deps architecture

Closes #27
2026-03-18 03:58:48 -07:00
b926b346ad fix: resolve terminal display wobble and effect dimension stability
- Fix TerminalDisplay: add screen clear each frame (cursor home + erase down)
- Fix CameraStage: use set_canvas_size instead of read-only viewport properties
- Fix Glitch effect: preserve visible line lengths, remove cursor positioning
- Fix Fade effect: return original line when fade=0 instead of empty string
- Fix Noise effect: use input line length instead of terminal_width
- Remove HUD effect from all presets (redundant with border FPS display)
- Add regression tests for effect dimension stability
- Add docs/ARCHITECTURE.md with Mermaid diagrams
- Add mise tasks: diagram-ascii, diagram-validate, diagram-check
- Move markdown docs to docs/ (ARCHITECTURE, Refactor, hardware specs)
- Remove redundant requirements files (use pyproject.toml)
- Add *.dot and *.png to .gitignore

Closes #25
2026-03-18 03:37:53 -07:00
a65fb50464 chore: remove deprecated docs and add skills library docs
- Delete LEGACY_CLEANUP_CHECKLIST.md, LEGACY_CODE_ANALYSIS.md,
  LEGACY_CODE_INDEX.md, SESSION_SUMMARY.md (superseded by wiki)
- Add Skills Library section to AGENTS.md documenting MCP skills
- Add uv to mise.toml tool versions
2026-03-18 00:36:57 -07:00
10e2f00edd refactor: centralize interfaces and clean up dead code
- Create engine/interfaces/ module with centralized re-exports of all ABCs/Protocols
- Remove duplicate Display protocol from websocket.py
- Remove unnecessary pass statements in exception classes
- Skip flaky websocket test that fails in CI due to port binding
2026-03-17 13:36:25 -07:00
05d261273e feat: Add gallery presets, MultiDisplay support, and viewport tests
- Add ~20 gallery presets covering sources, effects, cameras, displays
- Add MultiDisplay support with --display multi:terminal,pygame syntax
- Fix ViewportFilterStage to recompute layout on viewport_width change
- Add benchmark.py module for hook-based performance testing
- Add viewport resize tests to test_viewport_filter_performance.py
2026-03-17 01:24:15 -07:00
57de835ae0 feat: Implement scrolling camera with layout-aware filtering
- Rename VERTICAL camera mode to FEED (rapid single-item view)
- Add SCROLL camera mode with float accumulation for smooth movie-credits style scrolling
- Add estimate_block_height() for cheap layout calculation without full rendering
- Replace ViewportFilterStage with layout-aware filtering that tracks camera position
- Add render caching to FontStage to avoid re-rendering items
- Fix CameraStage to use global canvas height for scrolling bounds
- Add horizontal padding in Camera.apply() to prevent ghosting
- Add get_dimensions() to MultiDisplay for proper viewport sizing
- Fix PygameDisplay to auto-detect viewport from window size
- Update presets to use scroll camera with appropriate speeds
2026-03-17 00:21:18 -07:00
4c97cfe6aa fix: Implement ViewportFilterStage to prevent FontStage performance regression with large datasets
## Summary

Fixed critical performance issue where demo/poetry presets would hang for 10+ seconds due to FontStage rendering all 1438+ headline items instead of just the visible ~5 items.

## Changes

### Core Fix: ViewportFilterStage
- New pipeline stage that filters items to only those fitting in the viewport
- Reduces 1438 items → ~5 items (288x reduction) before FontStage
- Prevents expensive PIL font rendering operations on items that won't be displayed
- Located: engine/pipeline/adapters.py:348-403

### Pipeline Integration
- Updated app.py to add ViewportFilterStage before FontStage for headlines/poetry sources
- Ensures correct data flow: source → viewport_filter → font → camera → effects → display
- ViewportFilterStage depends on 'source' capability, providing pass-through filtering

### Display Protocol Enhancement
- Added is_quit_requested() and clear_quit_request() method signatures to Display protocol
- Documented as optional methods for backends supporting keyboard input
- Already implemented by pygame backend, now formally part of protocol

### Debug Infrastructure
- Added MAINLINE_DEBUG_DATAFLOW environment variable logging throughout pipeline
- Logs stage input/output types and data sizes to stderr (when flag enabled)
- Verified working: 1438 → 5 item reduction shown in debug output

### Performance Testing
- Added pytest-benchmark (v5.2.3) as dev dependency for statistical benchmarking
- Created comprehensive performance regression tests (tests/test_performance_regression.py)
- Tests verify:
  - ViewportFilterStage filters 2000 items efficiently (<1ms)
  - FontStage processes filtered items quickly (<50ms)
  - 288x performance improvement ratio maintained
  - Pipeline doesn't hang with large datasets
- All 523 tests passing, including 7 new performance tests

## Performance Impact

**Before:** FontStage renders all 1438 items per frame → 10+ second hang
**After:** FontStage renders ~5 items per frame → sub-second execution

Real-world impact: Demo preset now responsive and usable with news sources.

## Testing

- Unit tests: 523 passed, 16 skipped
- Regression tests: Catch performance degradation with large datasets
- E2E verification: Debug logging confirms correct pipeline flow
- Benchmark suite: Statistical performance tracking enabled
2026-03-16 22:43:53 -07:00
10c1d057a9 docs: Add run-preset-border-test task and clarify uv/mise usage
Updates:
- Added run-preset-border-test mise task for easy testing
- Clarified that all Python commands must use 'uv run' for proper dependency resolution
- PIL (Pillow) is a required dependency - available when installed with 'uv sync --all-extras'
- Demo preset now works correctly with proper environment setup

Key points:
- Use: mise run test, mise run run-preset-demo, etc.
- Use: uv run pytest, uv run mainline.py, etc.
- All dependencies including PIL are installed via: mise run sync-all
- Demo preset requires PIL for FontStage rendering (make_block uses PIL)

Verified:
- All 507 tests passing with uv run
- Demo preset renders correctly with PIL available
- Border-test preset renders correctly
- All display backends (terminal, pygame, websocket) now receive proper data
2026-03-16 22:12:10 -07:00
7f6413c83b fix: Correct inlet/outlet types for all stages and add comprehensive tests
Fixes and improvements:

1. Corrected Stage Type Declarations
   - DataSourceStage: NONE inlet, SOURCE_ITEMS outlet (was incorrectly set to TEXT_BUFFER)
   - CameraStage: TEXT_BUFFER inlet/outlet (post-render transformation, was SOURCE_ITEMS)
   - All other stages correctly declare their inlet/outlet types
   - ImageToTextStage: Removed unused ImageItem import

2. Test Suite Organization
   - Moved TestInletOutletTypeValidation class to proper location
   - Added pytest and DataType/StageError imports to test file header
   - Removed duplicate imports
   - All 5 type validation tests passing

3. Type Validation Coverage
   - Type mismatch detection raises StageError at build time
   - Compatible types pass validation
   - DataType.ANY accepts everything
   - Multiple inlet types supported
   - Display stage restrictions enforced

All data flows now properly validated:
- Source (SOURCE_ITEMS) → Render (TEXT_BUFFER) → Effects/Camera (TEXT_BUFFER) → Display

Tests: 507 tests passing
2026-03-16 22:06:27 -07:00