genewildish/Mainline
1
0
Fork 1
Code Issues Pull Requests 4 Packages Projects Releases Wiki Activity

refactor: Make EffectPlugin an abstract base class, update effects to inherit from it, and improve plugin discovery. #32

Merged
genewildish merged 1 commits from chore/plugin-migration into main 2026-03-19 06:15:42 +00:00
Conversation 0 Commits 1 Files Changed 6 +45 -15
genewildish commented 2026-03-19 06:13:04 +00:00
Owner
Copy Link

chore: migrate effect plugins to ABC paradigm

Updates the effect plugin system to use proper ABC (Abstract Base Class) inheritance in preparation for david's
feature/vector_display rebase.

Changes:

  • EffectPlugin now inherits from ABC with @abstractmethod decorators for process() and configure()
  • All 4 plugins (NoiseEffect, FadeEffect, GlitchEffect, FirehoseEffect) updated to explicitly inherit from EffectPlugin
  • Discovery mechanism switched from duck-typing to issubclass() check for robustness
  • Added camera_x field to EffectContext (defaults to 0, available for camera-aware effects)
  • Added create_effect_context() factory function with sensible defaults

Why:

  • Standardizes plugin interface on the ABC approach david's branch uses
  • Reduces merge conflicts when his rebase lands
  • Better error messages: missing method implementations fail at plugin load time, not at runtime
  • All tests passing (259/262; 3 pre-existing failures unrelated to this change)
chore: migrate effect plugins to ABC paradigm Updates the effect plugin system to use proper ABC (Abstract Base Class) inheritance in preparation for david's feature/vector_display rebase. Changes: - EffectPlugin now inherits from ABC with @abstractmethod decorators for process() and configure() - All 4 plugins (NoiseEffect, FadeEffect, GlitchEffect, FirehoseEffect) updated to explicitly inherit from EffectPlugin - Discovery mechanism switched from duck-typing to issubclass() check for robustness - Added camera_x field to EffectContext (defaults to 0, available for camera-aware effects) - Added create_effect_context() factory function with sensible defaults Why: - Standardizes plugin interface on the ABC approach david's branch uses - Reduces merge conflicts when his rebase lands - Better error messages: missing method implementations fail at plugin load time, not at runtime - All tests passing (259/262; 3 pre-existing failures unrelated to this change)
genewildish added 1 commit 2026-03-19 06:13:05 +00:00
refactor: Make EffectPlugin an abstract base class, update effects to inherit from it, and improve plugin discovery. edd1416407
genewildish merged commit 0819f8d160 into main 2026-03-19 06:15:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
genewildish
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: genewildish/Mainline#32
Delete Branch "chore/plugin-migration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?