david
501e1b7e23
## Summary This PR fixes the release workflow to properly handle version bumping on PR merge and uses the new Docker registry authentication secrets. ## Changes ### Release Workflow (release.yml) - **Version Bumping**: Now automatically bumps version on PR merge - Determines bump type from commit messages (major/minor/patch) - Commits version bump to `package.json` and `CHANGELOG.md` - Creates git tag for the release - **Docker Registry Auth**: Uses `DOCKER_LOGIN` and `DOCKER_PASSWORD` secrets - Falls back gracefully if secrets are not configured - **Tag Handling**: Checks if tag exists before creating (prevents failures) ### PR Workflow (pr.yml) - NEW - Runs unit tests on every PR - Analyzes commits to suggest bump type - Comments the suggested bump type on the PR ### Documentation - Added `WORKFLOW_ARCHITECTURE.md` explaining the workflow design ## Workflow Architecture **Two-step process:** 1. **PR Workflow** (on PR): Analyzes commits and suggests bump type 2. **Release Workflow** (on merge): Bumps version, creates tag, builds Docker image ## Benefits 1. **No CI Loops**: Version bump commits are detected and skipped 2. **Clear Communication**: PR comments inform developers of version impact 3. **Semantic Versioning**: Automated adherence to semver rules 4. **Traceability**: Git tags and changelog reflect all changes ## Testing The new workflows will be tested when this PR is merged. Closes #13 (Add database test safety configuration) Reviewed-on: #17 Co-authored-by: David Gwilliam <dhgwilliam@gmail.com> Co-committed-by: David Gwilliam <dhgwilliam@gmail.com>
130 lines
3.4 KiB
YAML
130 lines
3.4 KiB
YAML
name: Pull Request
|
|
|
|
on:
|
|
pull_request:
|
|
branches:
|
|
- main
|
|
|
|
jobs:
|
|
unit-tests:
|
|
runs-on: ubuntu-latest
|
|
container:
|
|
image: node:20-alpine
|
|
options: --user root
|
|
|
|
steps:
|
|
- name: Install system dependencies
|
|
run: |
|
|
apk add --no-cache bash git
|
|
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Install dependencies
|
|
run: npm ci
|
|
|
|
- name: Run unit tests
|
|
run: npm run test:run
|
|
|
|
acceptance-tests:
|
|
runs-on: ubuntu-latest
|
|
needs: unit-tests
|
|
container:
|
|
image: node:20-alpine
|
|
options: --user root
|
|
env:
|
|
DATABASE_PROVIDER: sqlite
|
|
DATABASE_URL: file:./prisma/ci.db
|
|
BETTER_AUTH_SECRET: test-secret-key-for-ci-only
|
|
|
|
steps:
|
|
- name: Install system dependencies
|
|
run: |
|
|
apk add --no-cache bash git
|
|
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Install dependencies
|
|
run: npm ci
|
|
|
|
- name: Generate Prisma client
|
|
run: npx prisma generate
|
|
|
|
- name: Setup SQLite database
|
|
run: |
|
|
# Create SQLite database file
|
|
mkdir -p prisma
|
|
npx prisma migrate deploy
|
|
|
|
- name: Run acceptance tests
|
|
run: npm run test:acceptance
|
|
env:
|
|
DATABASE_PROVIDER: sqlite
|
|
DATABASE_URL: file:./prisma/ci.db
|
|
BETTER_AUTH_SECRET: test-secret-key-for-ci-only
|
|
|
|
analyze-bump-type:
|
|
runs-on: ubuntu-latest
|
|
needs: acceptance-tests
|
|
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Analyze commits for bump type
|
|
id: bump_type
|
|
run: |
|
|
# Get the merge base and PR commits
|
|
git fetch origin main:main 2>/dev/null || true
|
|
MERGE_BASE=$(git merge-base HEAD main 2>/dev/null || echo "HEAD~1")
|
|
|
|
# Analyze commits in this PR
|
|
COMMITS=$(git log --oneline ${MERGE_BASE}..HEAD 2>/dev/null || git log --oneline -10)
|
|
|
|
echo "Commits in this PR:"
|
|
echo "$COMMITS"
|
|
echo ""
|
|
|
|
# Determine bump type
|
|
if echo "$COMMITS" | grep -qE "(BREAKING CHANGE|!:)"; then
|
|
BUMP="major"
|
|
REASON="Breaking change detected in commit messages"
|
|
elif echo "$COMMITS" | grep -qE "^feat"; then
|
|
BUMP="minor"
|
|
REASON="Feature commits detected"
|
|
else
|
|
BUMP="patch"
|
|
REASON="Defaulting to patch (fixes or other changes)"
|
|
fi
|
|
|
|
echo "Suggested bump type: $BUMP"
|
|
echo "Reason: $REASON"
|
|
echo "bump=$BUMP" >> $GITHUB_OUTPUT
|
|
echo "reason=$REASON" >> $GITHUB_OUTPUT
|
|
|
|
- name: Comment bump type on PR
|
|
uses: actions/github-script@v7
|
|
with:
|
|
script: |
|
|
const bump = '${{ steps.bump_type.outputs.bump }}';
|
|
const reason = '${{ steps.bump_type.outputs.reason }}';
|
|
|
|
const comment = `
|
|
## 🏷️ Version Bump Analysis
|
|
|
|
**Suggested bump type:** \`${bump.toUpperCase()}\`
|
|
**Reason:** ${reason}
|
|
|
|
This PR will bump the version to the next ${bump} version when merged.
|
|
`;
|
|
|
|
github.rest.issues.createComment({
|
|
issue_number: context.issue.number,
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
body: comment
|
|
});
|