ci-image-improvements #18

Merged
david merged 12 commits from ci-image-improvements into main 2026-04-01 06:14:26 +00:00

12 Commits

Author SHA1 Message Date
david d24e810ad1 refactor: revert CI image approach and use standard npm ci in workflows
Test / unit-tests (push) Successful in 2m32s
Pull Request / unit-tests (pull_request) Successful in 2m36s
Pull Request / acceptance-tests (pull_request) Failing after 4m59s
Pull Request / analyze-bump-type (pull_request) Has been skipped
The CI image approach with pre-installed dependencies doesn't work with Gitea Actions due to workspace mounting issues. When Gitea Actions runs a container job, it mounts the workspace at a specific path (e.g., /workspace/david/euchre_camp), which hides the container's /app directory where dependencies were installed.

Changes:
- Reverted pr.yml unit-tests to use node:20-alpine with npm ci
- Updated pr.yml acceptance-tests to use mcr.microsoft.com/playwright image with npm ci
- Updated test.yml to use node:20-alpine with npm ci
- Removed ci-image-builder.yml workflow
- Removed Dockerfile.ci and build-ci-image.sh
- Updated AGENTS.md and README.md to document the deprecation
- Updated justfile to remove CI image commands

The standard approach of running npm ci in each workflow is the recommended approach for Gitea Actions.
2026-03-31 23:10:50 -07:00
david 397594a9df fix: symlink from /app/node_modules to workspace
Test / unit-tests (push) Failing after 53s
Pull Request / unit-tests (pull_request) Failing after 54s
Pull Request / acceptance-tests (pull_request) Has been skipped
Pull Request / analyze-bump-type (pull_request) Has been skipped
2026-03-31 23:04:22 -07:00
david 4116884f9f fix: add /app/node_modules to PATH and NODE_PATH
Test / unit-tests (push) Failing after 11s
Pull Request / unit-tests (pull_request) Failing after 10s
Pull Request / acceptance-tests (pull_request) Has been skipped
Pull Request / analyze-bump-type (pull_request) Has been skipped
2026-03-31 23:02:56 -07:00
david b445d9044a chore: revert Dockerfile back to /app directory
Test / unit-tests (push) Failing after 8s
Pull Request / unit-tests (pull_request) Failing after 8s
Pull Request / acceptance-tests (pull_request) Has been skipped
Pull Request / analyze-bump-type (pull_request) Has been skipped
2026-03-31 23:01:48 -07:00
david 81c93bafc1 fix: use NODE_PATH env var instead of symlinks 2026-03-31 23:01:36 -07:00
david ba180ae6e1 fix: move node_modules to /workspace in CI image and update symlink
Test / unit-tests (push) Failing after 9s
Pull Request / unit-tests (pull_request) Failing after 9s
Pull Request / acceptance-tests (pull_request) Has been skipped
Pull Request / analyze-bump-type (pull_request) Has been skipped
2026-03-31 22:57:10 -07:00
david c611c68822 fix: use symlinks to link node_modules from container
Test / unit-tests (push) Failing after 52s
Pull Request / unit-tests (pull_request) Failing after 52s
Pull Request / acceptance-tests (pull_request) Has been skipped
Pull Request / analyze-bump-type (pull_request) Has been skipped
2026-03-31 22:53:40 -07:00
david 4c2687498f fix: update workflows to checkout in /app directory
Test / unit-tests (push) Failing after 5s
Pull Request / unit-tests (pull_request) Failing after 6s
Pull Request / acceptance-tests (pull_request) Has been skipped
Pull Request / analyze-bump-type (pull_request) Has been skipped
2026-03-31 22:41:11 -07:00
david 3983049d2c fix: use correct docker registry and image name
Pull Request / unit-tests (pull_request) Failing after 9s
Pull Request / acceptance-tests (pull_request) Has been skipped
Pull Request / analyze-bump-type (pull_request) Has been skipped
Test / unit-tests (push) Failing after 8s
2026-03-31 22:19:54 -07:00
david 941d857feb docs: update documentation with CI image info 2026-03-31 22:19:09 -07:00
david b686c3673e chore: add script for building CI image locally 2026-03-31 22:19:06 -07:00
david dfd66cde0b ci: add CI image builder workflow and Dockerfile 2026-03-31 22:19:03 -07:00