Files
knox/main.go
david 52c4d1f1e6 fix: derived-state determinism, error visibility, metrics naming, HTTP hardening
- rebuild: fold observations per fingerprint in a total order
  (hcl DESC, node_id DESC, id DESC) so two nodes with identical logs
  rebuild identical entries (was: arbitrary bare-column row, merge-order
  dependent)
- threads: CreateThreadCluster uses INSERT OR IGNORE + existing-id
  fallback — concurrent auto-threaders converge instead of hitting UNIQUE
- errors surfaced instead of swallowed: scanEntries returns rows.Err(),
  Stats() fails fast on query errors, AutoLinkThreadObservations /
  linkTemporalNeighbors / golden-thread linking propagate failures,
  AddThreadNote + LinkObservationToThread write under one tx,
  watch records session upsert failures
- gossip client: push checks HTTP status and reports errors (a broken
  push direction no longer looks like a silent success); gossip diff
  gets a 10s timeout so a dead peer cannot hang the CLI
- ingest: failed source sweeps (obsidian/browser/gitea) are logged,
  and -d's help text now states its file-only scope
- watch --quiet: fatal errors go to stderr instead of io.Discard
- main: cobra SilenceErrors/SilenceUsage (errors print once, usage is
  not dumped on runtime failures); knox mcp exits 0 on SIGINT/SIGTERM
- metrics: drop _total suffix from gauges (knox_observations,
  knox_entries, knox_projects, knox_sessions, knox_peers, knox_threads);
  _total stays on counters per Prometheus convention
- http: ReadHeaderTimeout + IdleTimeout on gossip, metrics, and web servers

tests: concurrent cluster-create idempotency, HCL-order rebuild fold
(both merge orders), push HTTP-error surfacing; full suite + -race pass,
gofmt clean
2026-09-17 02:28:08 -07:00

97 lines
2.5 KiB
Go

package main
import (
"context"
"errors"
"fmt"
"log"
"os"
knoxcmd "github.com/david/knox/internal/cmd"
"github.com/david/knox/internal/db"
knoxserver "github.com/david/knox/internal/server"
mcpServer "github.com/mark3labs/mcp-go/server"
"github.com/spf13/cobra"
)
func newServeCmd(kdb *db.KnoxDB) *cobra.Command {
var port int
cmd := &cobra.Command{
Use: "serve",
Short: "Start web UI for the knowledge index",
RunE: func(c *cobra.Command, args []string) error {
srv := knoxserver.New(kdb)
addr := fmt.Sprintf("localhost:%d", port)
log.Printf("[knox] web UI at http://%s", addr)
return srv.Serve(addr)
},
}
cmd.Flags().IntVarP(&port, "port", "p", 8924, "HTTP port")
return cmd
}
func main() {
dbPath := os.Getenv("KNOX_DB")
if dbPath == "" {
home, err := os.UserHomeDir()
if err != nil {
log.Fatalf("cannot get home dir: %v", err)
}
dbPath = home + "/.local/share/knox/index.db"
}
kdb, err := db.Open(dbPath)
if err != nil {
log.Fatalf("cannot open db: %v", err)
}
defer kdb.Close()
root := &cobra.Command{
Use: "knox",
Short: "Knowledge index & session tracker for opencode",
Long: `Knox watches opencode session data, ingests knowledge fingerprints,
and maintains a searchable index. Use 'knox watch' for daemon mode.`,
}
root.AddCommand(knoxcmd.NewWatchCmd(kdb))
root.AddCommand(knoxcmd.NewStatusCmd(kdb))
root.AddCommand(knoxcmd.NewQueryCmd(kdb))
root.AddCommand(knoxcmd.NewRecentCmd(kdb))
root.AddCommand(knoxcmd.NewReflectCmd(kdb))
root.AddCommand(knoxcmd.NewIngestCmd(kdb))
root.AddCommand(knoxcmd.NewThreadCmd(kdb))
root.AddCommand(knoxcmd.NewBrowserCmd(kdb))
root.AddCommand(knoxcmd.NewObsidianCmd(kdb))
root.AddCommand(knoxcmd.NewTopicsCmd(kdb))
root.AddCommand(knoxcmd.NewGiteaCmd(kdb))
root.AddCommand(knoxcmd.NewGitCmd(kdb))
root.AddCommand(knoxcmd.NewReconcileCmd(kdb))
root.AddCommand(knoxcmd.NewGossipCmd(kdb))
root.AddCommand(newServeCmd(kdb))
// MCP server subcommand
mcpCmd := &cobra.Command{
Use: "mcp",
Short: "Start MCP server for opencode integration",
RunE: func(c *cobra.Command, args []string) error {
s := knoxcmd.NewMCPServer(kdb)
log.Printf("[knox] starting MCP stdio server")
if err := mcpServer.ServeStdio(s); err != nil {
// SIGINT/SIGTERM cancels the server context: clean shutdown,
// not a failure.
if errors.Is(err, context.Canceled) {
return nil
}
return err
}
return nil
},
}
root.AddCommand(mcpCmd)
if err := root.Execute(); err != nil {
fmt.Fprintln(os.Stderr, err)
os.Exit(1)
}
}