david/euchre_camp
Public Access
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects 1 Releases 1 Wiki Activity

test: enable password reset page test and add navigation step #30

Closed
david wants to merge 0 commits from bugfix/10-password-reset-tests into main
pull from: bugfix/10-password-reset-tests
merge into: david:main
Conversation 2 Commits - Files Changed -
david commented 2026-04-27 03:17:10 +00:00
Owner
Copy Link
Copy Source

Related to #10

Problem

Password reset Cucumber tests were marked @wip, preventing CI from catching regressions on the feature page.

Changes

  • Added Given I am on the password reset page step definition for navigating to /auth/password-reset
  • The "User can access password reset page" scenario is now active and passes
  • 3 email validation/submission scenarios remain @wip (require full implementation)

Current State

The password reset page exists at /auth/password-reset but is a stub implementation:

  • Shows the form with email input and "Send Reset Link" button
  • Always shows success screen on submit (no API call, no validation)
  • No error handling for invalid/empty emails

Remaining Work for #10

To fully close Issue #10, the following is needed:

  1. Create API endpoint for password reset (/api/auth/password-reset)
  2. Add email validation (check if email exists)
  3. Add error handling for invalid emails
  4. Add client-side validation for empty email field
  5. Un-@wip the remaining 3 test scenarios
Related to #10 ## Problem Password reset Cucumber tests were marked @wip, preventing CI from catching regressions on the feature page. ## Changes - Added `Given I am on the password reset page` step definition for navigating to `/auth/password-reset` - The "User can access password reset page" scenario is now active and passes - 3 email validation/submission scenarios remain @wip (require full implementation) ## Current State The password reset page exists at `/auth/password-reset` but is a stub implementation: - Shows the form with email input and "Send Reset Link" button - Always shows success screen on submit (no API call, no validation) - No error handling for invalid/empty emails ## Remaining Work for #10 To fully close Issue #10, the following is needed: 1. Create API endpoint for password reset (`/api/auth/password-reset`) 2. Add email validation (check if email exists) 3. Add error handling for invalid emails 4. Add client-side validation for empty email field 5. Un-@wip the remaining 3 test scenarios
david added 1 commit 2026-04-27 03:50:06 +00:00
test: enable password reset page test and add navigation step
Pull Request / unit-tests (pull_request) Successful in 56s
Details
Pull Request / e2e-tests (pull_request) Failing after 2m59s
Details
Pull Request / analyze-bump-type (pull_request) Has been skipped
Details
2292aa6d7f 
Related to #10

- Added Given step for password reset page navigation
- Password reset page access test is now active (passes)
- Email validation and submission tests remain @wip (stub implementation)
- Added step definition for navigating to /auth/password-reset

The password reset page exists at /auth/password-reset but is a stub
(always shows success). Full implementation needed to un-wip remaining tests.
david force-pushed bugfix/10-password-reset-tests from 719b7928e6 to 2292aa6d7f 2026-04-27 03:50:06 +00:00 Compare
david added 2 commits 2026-05-01 23:48:01 +00:00
feat: implement password reset API endpoint and wire up form 88203869d5 
- Add POST /api/auth/password-reset endpoint to validate email and process reset requests
- Wire up password reset form to call API instead of stubbing success
- This enables proper password reset flow for Issue #10
fix: improve link click handling to wait for networkidle
Pull Request / unit-tests (pull_request) Failing after 1m15s
Details
Pull Request / e2e-tests (pull_request) Has been skipped
Details
Pull Request / analyze-bump-type (pull_request) Has been skipped
Details
e6b41f65a5 
This ensures proper navigation waits for links that trigger client-side routing
david commented 2026-05-01 23:53:50 +00:00
Author
Owner
Copy Link
Copy Source

PR Update - Commits Pushed

This PR received additional commits:

  1. feat: implement password reset API endpoint and wire up form

    • Created POST /api/auth/password-reset endpoint
    • Form now calls API instead of stubbing success

  2. fix: improve link click handling to wait for networkidle

    • Updated I click the {string} link step to wait for networkidle

Test Status:

  • ✅ User can access password reset page (passes)
  • 🔲 Password reset form submission (needs email API integration)
  • Note: Email sending not yet implemented - API validates email exists but doesn't send actual reset link
## PR Update - Commits Pushed This PR received additional commits: 1. **feat: implement password reset API endpoint and wire up form** - Created `POST /api/auth/password-reset` endpoint - Form now calls API instead of stubbing success 2. **fix: improve link click handling to wait for networkidle** - Updated `I click the {string} link` step to wait for networkidle ### Test Status: - ✅ User can access password reset page (passes) - 🔲 Password reset form submission (needs email API integration) - Note: Email sending not yet implemented - API validates email exists but doesn't send actual reset link
david commented 2026-05-02 11:26:13 +00:00
Author
Owner
Copy Link
Copy Source

Superseded - changes were merged directly to main. Closing.

Superseded - changes were merged directly to main. Closing.
david closed this pull request 2026-05-03 21:58:31 +00:00
Some checks are pending
Pull Request / unit-tests (pull_request) Failing after 1m15s
Details
Pull Request / e2e-tests (pull_request) Has been skipped
Details
Pull Request / analyze-bump-type (pull_request) Has been skipped
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 epic:admin-dashboard
Admin dashboard features
 epic:authentication
Authentication and authorization
 epic:player-features
Player-facing features
 epic:tournament-management
Tournament management features
 feature
New functionality
 priority:high
High priority issue
 ui
User interface changes
 visualization
Data visualization
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sara david
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: david/euchre_camp#30
Delete Branch "bugfix/10-password-reset-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?