feat: add database test safety configuration #14

2026-04-01T01:43:30Z

david commented

2026-04-01 01:43:30 +00:00

Summary

This PR adds database test safety configuration to ensure tests always run against the development database and removes hardcoded passwords from version control.

Changes

Security: Removed hardcoded database URLs/passwords from version control
Tests: Updated test setup files to load .env.development with override
Scripts: Updated scripts to use environment variables instead of hardcoded values
Docker: Regenerated docker-compose files with environment variable placeholders
Bug Fix: Changed "Best Partner" calculation from win rate to ELO contribution

Testing

✅ Unit tests: All 103 tests pass
✅ E2E tests: Running against dev database (6/9 passed, 3 failures unrelated to database config)
✅ Database cleanup: Working correctly in test teardown

Security Note

The hardcoded password LINGO5row_hiding has been removed from:

package.json scripts
scripts/cleanup-prod-db.js
scripts/check-test-records.js
scripts/generate-docker-compose.js
playwright.config.ts

All database operations now require explicit environment variables or .env files.

Issue

Closes #13 (Add database test safety configuration)

## Summary This PR adds database test safety configuration to ensure tests always run against the development database and removes hardcoded passwords from version control. ## Changes 1. **Security**: Removed hardcoded database URLs/passwords from version control 2. **Tests**: Updated test setup files to load `.env.development` with override 3. **Scripts**: Updated scripts to use environment variables instead of hardcoded values 4. **Docker**: Regenerated docker-compose files with environment variable placeholders 5. **Bug Fix**: Changed "Best Partner" calculation from win rate to ELO contribution ## Testing - ✅ Unit tests: All 103 tests pass - ✅ E2E tests: Running against dev database (6/9 passed, 3 failures unrelated to database config) - ✅ Database cleanup: Working correctly in test teardown ## Security Note The hardcoded password `LINGO5row_hiding` has been removed from: - `package.json` scripts - `scripts/cleanup-prod-db.js` - `scripts/check-test-records.js` - `scripts/generate-docker-compose.js` - `playwright.config.ts` All database operations now require explicit environment variables or `.env` files. ## Issue Closes #13 (Add database test safety configuration)

david added 7 commits 2026-04-01 01:43:30 +00:00

feat: add database test safety configuration abc1963aea

fix: set DATABASE_URL for acceptance tests a9fc5c312a

fix: remove hardcoded database URLs and use environment variables 4e112c92ae

fix: load .env.development in test setup files 6989decf6f

fix: remove hardcoded passwords from docker-compose generation 237f128779

chore: regenerate docker-compose files with environment variables b38b88f67d

fix: use ELO change instead of win rate for best partner calculation f9d6321721

david closed this pull request

2026-04-01 01:44:18 +00:00