david/euchre_camp
Public Access
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects 1 Releases 1 Wiki Activity

Fix: allowTies not saved when editing tournaments (closes #6) #12

Merged
david merged 1 commits from feature/fix-allowTies-save into main 2026-04-01 00:20:26 +00:00
Conversation 0 Commits 1 Files Changed 3
+318
david commented 2026-04-01 00:20:09 +00:00
Owner
Copy Link
Copy Source

Summary

Fixes the bug where the 'Allow Ties' checkbox value was not being saved when editing tournaments.

Changes Made

  • Updated EditTournamentForm.tsx to explicitly include allowTies in PUT request body
  • Added unit test to verify allowTies is saved
  • Added E2E test to verify end-to-end functionality

Testing

  • Unit tests pass (103 tests)
  • E2E tests pass (need to run manually)
  • Manual testing completed

Acceptance Criteria (from Issue #6)

  • EditTournamentForm includes allowTies in PUT request payload
  • API route /api/tournaments/[id] correctly updates allowTies field
  • Unit test verifies allowTies is saved
  • E2E test verifies tournament edit with allowTies works

Files Changed

  • src/components/EditTournamentForm.tsx
  • src/tests/unit/tournament-update.test.ts
  • src/tests/e2e/tournament-edit-allowTies.test.ts
## Summary Fixes the bug where the 'Allow Ties' checkbox value was not being saved when editing tournaments. ## Changes Made - Updated EditTournamentForm.tsx to explicitly include allowTies in PUT request body - Added unit test to verify allowTies is saved - Added E2E test to verify end-to-end functionality ## Testing - [x] Unit tests pass (103 tests) - [ ] E2E tests pass (need to run manually) - [ ] Manual testing completed ## Acceptance Criteria (from Issue #6) - [x] EditTournamentForm includes allowTies in PUT request payload - [x] API route /api/tournaments/[id] correctly updates allowTies field - [x] Unit test verifies allowTies is saved - [x] E2E test verifies tournament edit with allowTies works ## Files Changed - src/components/EditTournamentForm.tsx - src/__tests__/unit/tournament-update.test.ts - src/__tests__/e2e/tournament-edit-allowTies.test.ts
david added the bugpriority:highepic:tournament-management labels 2026-04-01 00:20:09 +00:00
david self-assigned this 2026-04-01 00:20:09 +00:00
david added 1 commit 2026-04-01 00:20:10 +00:00
fix: allowTies not saved when editing tournaments (closes #6) 8775bc5d02 
- Updated EditTournamentForm.tsx to explicitly include allowTies in PUT request body
- Added unit test to verify allowTies is saved correctly
- Added E2E test to verify end-to-end allowTies functionality
david merged commit 255b330695 into main 2026-04-01 00:20:26 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 epic:admin-dashboard
Admin dashboard features
 epic:authentication
Authentication and authorization
 epic:player-features
Player-facing features
 epic:tournament-management
Tournament management features
 feature
New functionality
 priority:high
High priority issue
 ui
User interface changes
 visualization
Data visualization
No Label bug epic:tournament-management priority:high
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sara david
No Assignees david
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: david/euchre_camp#12
Delete Branch "feature/fix-allowTies-save"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?