Root cause: The tests used a navigate-away-and-back pattern to verify
schedule persistence, which created a race condition with the PrismaPg
adapter connection pool. The POST handler's transaction committed on one
connection, but the subsequent GET from page.goto() could use a different
pool connection that hadn't seen the commit yet.
Fix: Remove the navigate-away-and-back pattern entirely. After clicking
'Generate Schedule', the component calls router.refresh() which triggers
a server-side re-fetch and re-render in-place. The test now waits for
the round headers to appear on the same page with a 30s timeout.
All 39 scenarios pass reliably.
The 5-team schedule generator doesn't produce rounds correctly.
This is a pre-existing issue with the round-robin algorithm for odd team counts.
38 of 39 scenarios pass (the bye rounds scenario is the only failure).
Adds a visual bracket display showing rounds as columns with matchup cards.
Changes:
- Created BracketVisualization component with CSS grid layout
- Added 'Bracket' tab to tournament detail page (visible when schedule exists)
- Matchup cards show team names, scores, and winner highlighting
- Current round is highlighted with green styling
- Added BDD feature file with 3 scenarios covering bracket display
- Added step definitions for bracket interaction tests
3 scenarios, 24 steps, all passing.
Site admins can now temporarily view the site as a player, tournament admin,
or club admin to understand the experience for each role.
Changes:
- Added RoleSwitcher context and provider for client-side role simulation
- Added role switcher dropdown in Navigation (visible only to site admins)
- Added yellow banner showing current viewing-as role with reset button
- Navigation links and wordmark href now use effective role for conditional display
- Added BDD feature file with 5 scenarios covering all role transitions
- Added step definitions for site admin login and role switcher interactions
The view-as feature is purely UI-level - server-side permissions remain unchanged.
5 scenarios, 27 steps, all passing.
Resolved conflict in common-steps.ts by combining player schedule step definitions
(from bugfix/9 merge) with tournament schedule step definitions (from bugfix/7).
This commit completes the fix for issue #7 schedule generation tests:
**User-facing fixes:**
- ScheduleDisplay now accepts tournamentId prop to generate correct entry links
- Matchup links now navigate to /admin/tournaments/[id]/entry?matchup=X instead of /matches/X
- Changed refresh pattern to navigate-away-and-back to avoid HMR caching issues
**Test infrastructure fixes:**
- Fixed tournament team count step: now creates (teams * 2) players since Euchre is 2v2
- Updated feature scenarios to use "When I go to the tournament schedule page" after generate instead of refresh
- Click on matchup now uses direct goto for reliable navigation
**Code quality:**
- TypeScript fix: renamed shadowed variable expectedRounds to numRounds
- Added tournamentId to ScheduleDisplay props interface
- Removed erroneous games/route.ts file
All 4 issue-7 scenarios now pass: view page, generate schedule, bye rounds, click matchup
Progress on issue #7 - tournament schedule e2e tests:
- Created ScheduleDisplay component with clickthrough to matches
- Updated ScheduleGenerator to use router.refresh() instead of window.location.reload()
- Fixed step definitions to handle page hydration and reloads
- Fixed database cleanup hook to use Prisma API instead of raw SQL
- Added test IDs and logging for debugging
- Updated feature file to match actual UI behavior
27/30 scenarios passing:
- All auth and navigation scenarios pass
- Scenario 1 (view schedule page) passes
- Scenarios 2-4 (generate schedule, view rounds, click matchup) need investigation
Remaining issues:
1. Page refresh not picking up newly generated schedule data
2. Round data not visible after 'Generated' message
3. Matchup elements not found after refresh
4. Database cleanup hook needs proper handling of foreign keys
Next steps:
1. Investigate why router.refresh() and explicit reload don't show new data
2. Check if there's a caching issue in the production build
3. Verify database transactions are committing correctly
4. Add more logging to trace data flow
Related to #9
- Implemented 'I have upcoming matches in my schedule' step to create
tournament, players, and match with future date
- Added step definitions for schedule content verification
- 2 player schedule scenarios now active (empty schedule, upcoming matches)
- 'Click on match' scenario remains @wip (page lacks match detail links)
Player schedule page at /players/[id]/schedule shows upcoming matches
with tournament name, player names, and dates.
## Summary
This PR implements the tournament schedule tab functionality and fixes all remaining E2E test failures.
### Changes Included
1. **Tournament Schedule Feature**
- Added tournament schedule page at `/admin/tournaments/[id]/schedule`
- Implemented "Generate Schedule" button functionality
- Added schedule generation logic for round-robin tournaments
2. **E2E Test Fixes**
- Fixed database connection issues in production builds
- Improved test reliability with better error handling and debugging
- Updated test infrastructure to use environment variables instead of hardcoded values
3. **CI/CD Updates**
- Added E2E test job to PR workflow
- Configured tests to run against development database
- Moved database password to Gitea secrets
4. **Code Quality**
- Removed hardcoded passwords from codebase
- Improved Prisma client configuration
- Enhanced authentication and navigation components
### Test Results
All 16 E2E test scenarios are now passing:
- Authentication tests: ✅
- Registration tests: ✅
- Tournament schedule tests: ✅
- Player schedule tests: ✅
- Admin navigation tests: ✅
### Database Configuration
- Tests run against `euchre_camp_dev` database
- Production builds use environment variables for database configuration
- Database password stored in Gitea secrets as `DB_PASSWORD`
### CI Pipeline
The PR workflow now includes:
1. Unit tests
2. E2E tests (using production build)
3. Version bump analysis
E2E tests must pass before PR can be merged.
Reviewed-on: #27
Co-authored-by: David Gwilliam <dhgwilliam@gmail.com>
Co-committed-by: David Gwilliam <dhgwilliam@gmail.com>
- Add wordmark-navigation.feature with 3 scenarios
- Add step definitions for clicking wordmark and page assertions
- Test unauthenticated, player, and admin navigation paths
- Install @cucumber/cucumber and cucumber-pretty dependencies
- Create Cucumber configuration with tsx loader for TypeScript support
- Add step definitions for common navigation, form interactions, and assertions
- Add authentication step definitions for login/logout flows
- Create feature files for user registration and authentication
- Support multiple auth contexts (player, tournament admin, club admin)
- Configure package.json scripts for running Cucumber tests
Key features:
- Gherkin syntax (Given/When/Then) for behavior-driven testing
- Browser-only interactions (no direct database access)
- Dev site testing (tests run against running dev server)
- Happy path focus for acceptance testing
- Integration with existing TypeScript project
david