feat: Implement tournament schedule tab and fix E2E tests (#27)
Release / release (push) Failing after 9s
Build CI Images / build-ci-base (push) Failing after 18s

## Summary

This PR implements the tournament schedule tab functionality and fixes all remaining E2E test failures.

### Changes Included

1. **Tournament Schedule Feature**
   - Added tournament schedule page at `/admin/tournaments/[id]/schedule`
   - Implemented "Generate Schedule" button functionality
   - Added schedule generation logic for round-robin tournaments

2. **E2E Test Fixes**
   - Fixed database connection issues in production builds
   - Improved test reliability with better error handling and debugging
   - Updated test infrastructure to use environment variables instead of hardcoded values

3. **CI/CD Updates**
   - Added E2E test job to PR workflow
   - Configured tests to run against development database
   - Moved database password to Gitea secrets

4. **Code Quality**
   - Removed hardcoded passwords from codebase
   - Improved Prisma client configuration
   - Enhanced authentication and navigation components

### Test Results
All 16 E2E test scenarios are now passing:
- Authentication tests: 
- Registration tests: 
- Tournament schedule tests: 
- Player schedule tests: 
- Admin navigation tests: 

### Database Configuration
- Tests run against `euchre_camp_dev` database
- Production builds use environment variables for database configuration
- Database password stored in Gitea secrets as `DB_PASSWORD`

### CI Pipeline
The PR workflow now includes:
1. Unit tests
2. E2E tests (using production build)
3. Version bump analysis

E2E tests must pass before PR can be merged.

Reviewed-on: #27
Co-authored-by: David Gwilliam <dhgwilliam@gmail.com>
Co-committed-by: David Gwilliam <dhgwilliam@gmail.com>
This commit was merged in pull request #27.
This commit is contained in:
2026-04-27 01:59:16 +00:00
committed by david
parent 75358bf20d
commit bb6be245b7
97 changed files with 7950 additions and 1341 deletions
+55 -7
View File
@@ -2,12 +2,15 @@
* Cucumber hooks for EuchreCamp E2E tests
*/
import { Before, After, BeforeAll, AfterAll } from '@cucumber/cucumber';
import { Before, After, BeforeAll, AfterAll, setDefaultTimeout } from '@cucumber/cucumber';
import { chromium, Browser } from '@playwright/test';
import { world } from './world';
import path from 'path';
import fs from 'fs';
// Set default timeout for Cucumber steps (30 seconds)
setDefaultTimeout(30000);
// Global browser instance
let browser: Browser;
@@ -23,6 +26,31 @@ if (fs.existsSync(envDevPath)) {
require('dotenv').config({ path: envDevPath, override: true });
}
// Database safety check - prevent tests from running against production
function isProductionDatabase(): boolean {
const dbUrl = process.env.DATABASE_URL || '';
return dbUrl.includes('euchre_camp') && !dbUrl.includes('_dev') && !dbUrl.includes('test');
}
if (isProductionDatabase()) {
console.error('');
console.error('='.repeat(80));
console.error('CRITICAL ERROR: Cucumber tests are attempting to run against PRODUCTION database!');
console.error('='.repeat(80));
console.error('');
console.error('Current DATABASE_URL:', process.env.DATABASE_URL);
console.error('');
console.error('Tests MUST run against a development/test database.');
console.error('');
console.error('To fix this:');
console.error(' 1. Set DATABASE_URL to a dev/test database');
console.error(' 2. Or run: npm run test:acceptance (which uses Playwright tests)');
console.error('');
console.error('Aborting test execution to prevent data corruption.');
console.error('');
process.exit(1);
}
/**
* Before all scenarios: Launch browser
*/
@@ -48,15 +76,35 @@ AfterAll(async function () {
* Before each scenario: Create new page context
*/
Before(async function () {
// Create new context and page
world.context = await browser.newContext();
world.page = await world.context.newPage();
try {
// Create new context and page
world.context = await browser.newContext();
world.page = await world.context.newPage();
} catch (error) {
console.error('❌ Failed to create new browser context:', error);
console.log('🌍 Attempting to relaunch browser...');
// Try to relaunch browser
try {
await browser.close();
} catch (e) {
// Ignore close errors
}
// Relaunch browser
browser = await chromium.launch({
headless: process.env.CI ? true : false,
});
// Retry creating context
world.context = await browser.newContext();
world.page = await world.context.newPage();
console.log('✅ Browser relaunched successfully');
}
// Log console messages for debugging
world.page.on('console', msg => {
if (msg.type() === 'error') {
console.log('❌ PAGE ERROR:', msg.text());
}
console.log(`🌍 BROWSER ${msg.type()}:`, msg.text());
});
// Log network errors