klubhaus/sideline
2
0
Fork 0
forked from genewildish/Mainline
Code Issues 5 Pull Requests Projects 1 Releases Wiki Activity

Story: EffectPlugin ABC and Registry #17

New Issue
Closed
opened 2026-03-18 06:27:01 +00:00 by david · 2 comments
david commented 2026-03-18 06:27:01 +00:00
Owner
Copy Link

As a developer
I want to add effects without modifying core code
So that the effects ecosystem can grow independently

Acceptance Criteria:

  • EffectPlugin ABC with process() and configure()
  • EffectRegistry discovers plugins
  • EffectChain executes in pipeline order
  • Runtime discovery via effects_plugins/init.py

Technical Tasks:

  • Refactor engine/effects/types.py: Add EffectPlugin ABC
  • Update engine/effects/__init__.py: EffectRegistry, EffectChain
  • Update engine/effects/controller.py: Use new system
  • Add tests in test_effects_controller.py
**As a** developer **I want** to add effects without modifying core code **So that** the effects ecosystem can grow independently **Acceptance Criteria:** - [ ] EffectPlugin ABC with process() and configure() - [ ] EffectRegistry discovers plugins - [ ] EffectChain executes in pipeline order - [ ] Runtime discovery via effects_plugins/__init__.py --- **Technical Tasks:** - Refactor `engine/effects/types.py`: Add EffectPlugin ABC - Update `engine/effects/__init__.py`: EffectRegistry, EffectChain - Update `engine/effects/controller.py`: Use new system - Add tests in `test_effects_controller.py`
david added this to the Mainline project 2026-03-18 07:12:13 +00:00
david added the status:feature-complete label 2026-03-18 07:15:17 +00:00
david added the status:tested label 2026-03-18 07:49:06 +00:00
david added the epic:#6 label 2026-03-18 07:56:00 +00:00
david added the epic:Effects label 2026-03-18 07:59:24 +00:00
david commented 2026-03-18 10:58:02 +00:00
Author
Owner
Copy Link

Refactoring effects_plugins/ to engine/effects/plugins/:

  • Enables better integration with the effects system
  • Follows capability-based dependency resolution architecture
  • Fixes import chains across the codebase

Commit: 4fb8843 refactor: move effects_plugins to engine/effects/plugins

Refactoring `effects_plugins/` to `engine/effects/plugins/`: - Enables better integration with the effects system - Follows capability-based dependency resolution architecture - Fixes import chains across the codebase Commit: `4fb8843 refactor: move effects_plugins to engine/effects/plugins`
david commented 2026-03-18 10:58:50 +00:00
Author
Owner
Copy Link

Superseded by #27 (standalone refactor ticket).

Superseded by #27 (standalone refactor ticket).
david closed this issue 2026-03-18 22:03:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
epic:#2
epic:#20
epic:#3
epic:#4
epic:#5
epic:#6
epic:Data Source
epic:Display Backend
epic:Display Tools
epic:Effects
epic:Pipeline Architecture
epic:Sensors
status:feature-complete
status:in-progress
status:released
status:tested
type:epic
type:epic
No Label epic:#6 epic:Effects status:feature-complete status:tested
Milestone
No items
No Milestone
Projects
Clear projects
No project Mainline
Assignees
Clear assignees
david genewildish
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: klubhaus/sideline#17
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?