klubhaus/sideline
2
0
Fork 0
forked from genewildish/Mainline
Code Issues 5 Pull Requests Projects 1 Releases Wiki Activity

refactor: move effects_plugins to engine/effects/plugins

Browse Source 
- Move effects_plugins/ to engine/effects/plugins/
- Update imports in engine/app.py
- Update imports in all test files
- Follows capability-based deps architecture

Closes #27
This commit is contained in:
David Gwilliam
2026-03-18 03:56:31 -07:00
parent b926b346ad
commit b37b2ccc73
16 changed files with 21 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/test_glitch_effect.py
View File

@@ -36,7 +36,7 @@ class TestGlitchEffectStability:
def test_glitch_preserves_line_count(self, effect_context, stable_buffer):
"""Glitch should not change the number of lines in buffer."""
from effects_plugins.glitch import GlitchEffect
from engine.effects.plugins.glitch import GlitchEffect
effect = GlitchEffect()
result = effect.process(stable_buffer, effect_context)
@@ -50,7 +50,7 @@ class TestGlitchEffectStability:
Note: Effects may add ANSI color codes, so we check VISIBLE length (stripped).
"""
from effects_plugins.glitch import GlitchEffect
from engine.effects.plugins.glitch import GlitchEffect
effect = GlitchEffect()
@@ -69,7 +69,7 @@ class TestGlitchEffectStability:
Regression test: Previously glitch used \\033[{row};1H which caused
conflicts with HUD and border rendering.
"""
from effects_plugins.glitch import GlitchEffect
from engine.effects.plugins.glitch import GlitchEffect
effect = GlitchEffect()
result = effect.process(stable_buffer, effect_context)
@@ -86,7 +86,7 @@ class TestGlitchEffectStability:
self, effect_context, stable_buffer
):
"""Glitch output should be deterministic given the same random seed."""
from effects_plugins.glitch import GlitchEffect
from engine.effects.plugins.glitch import GlitchEffect
effect = GlitchEffect()
effect.config = EffectConfig(enabled=True, intensity=1.0)
@@ -127,9 +127,9 @@ class TestEffectViewportStability:
def test_effect_chain_preserves_dimensions(self):
"""Effect chain should preserve buffer dimensions."""
from effects_plugins.fade import FadeEffect
from effects_plugins.glitch import GlitchEffect
from effects_plugins.noise import NoiseEffect
from engine.effects.plugins.fade import FadeEffect
from engine.effects.plugins.glitch import GlitchEffect
from engine.effects.plugins.noise import NoiseEffect
ctx = EffectContext(
terminal_width=80,
@@ -152,7 +152,9 @@ class TestEffectViewportStability:
assert len(buffer) == original_len, (
f"{effect.name} changed line count from {original_len} to {len(buffer)}"
)
for i, (orig_w, new_line) in enumerate(zip(original_widths, buffer, strict=False)):
for i, (orig_w, new_line) in enumerate(
zip(original_widths, buffer, strict=False)
):
visible_len = len(strip_ansi(new_line))
assert visible_len == orig_w, (
f"{effect.name} changed line {i} visible width from {orig_w} to {visible_len}"
@@ -181,7 +183,7 @@ class TestEffectTestMatrix:
pytest.skip("Border handled by display")
else:
effect_module = __import__(
f"effects_plugins.{effect_name}",
f"engine.effects.plugins.{effect_name}",
fromlist=[f"{effect_name.title()}Effect"],
)
effect_class = getattr(effect_module, f"{effect_name.title()}Effect")
@@ -213,7 +215,7 @@ class TestEffectTestMatrix:
"""Effects should not use cursor positioning (causes display conflicts)."""
try:
effect_module = __import__(
f"effects_plugins.{effect_name}",
f"engine.effects.plugins.{effect_name}",
fromlist=[f"{effect_name.title()}Effect"],
)
effect_class = getattr(effect_module, f"{effect_name.title()}Effect")