klubhaus/sideline
2
0
Fork 0
forked from genewildish/Mainline
Code Issues 5 Pull Requests Projects 1 Releases Wiki Activity

feat(figment): complete pipeline integration with native effect plugin

Browse Source 
- Add engine/effects/plugins/figment.py (native pipeline implementation)
- Add engine/figment_render.py, engine/figment_trigger.py, engine/themes.py
- Add 3 SVG assets in figments/ (Mexican/Aztec motif)
- Add engine/display/backends/animation_report.py for debugging
- Add engine/pipeline/adapters/frame_capture.py for frame capture
- Add test-figment preset to presets.toml
- Add cairosvg optional dependency to pyproject.toml
- Update EffectPluginStage to support is_overlay attribute (for overlay effects)
- Add comprehensive tests: test_figment_effect.py, test_figment_pipeline.py, test_figment_render.py
- Remove obsolete test_ui_simple.py
- Update TODO.md with test cleanup plan
- Refactor test_adapters.py to use real components instead of mocks

This completes the figment SVG overlay feature integration using the modern pipeline architecture, avoiding legacy effects_plugins. All tests pass (758 total).
This commit is contained in:
David Gwilliam
2026-03-21 13:09:37 -07:00
parent ef0c43266a
commit 7185005f9b
17 changed files with 1990 additions and 181 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
TODO.md
View File

@@ -19,6 +19,42 @@
- [x] Enumerate all effect plugin parameters automatically for UI control (intensity, decay, etc.)
- [ ] Implement pipeline hot-rebuild when stage toggles or params change, preserving camera and display state [#43](https://git.notsosm.art/david/Mainline/issues/43)
## Test Suite Cleanup & Feature Implementation
### Phase 1: Test Suite Cleanup (In Progress)
- [x] Port figment feature to modern pipeline architecture
- [x] Create `engine/effects/plugins/figment.py` (full port)
- [x] Add `figment.py` to `engine/effects/plugins/`
- [x] Copy SVG files to `figments/` directory
- [x] Update `pyproject.toml` with figment extra
- [x] Add `test-figment` preset to `presets.toml`
- [x] Update pipeline adapters for overlay effects
- [x] Clean up `test_adapters.py` (removed 18 mock-only tests)
- [x] Verify all tests pass (652 passing, 20 skipped, 58% coverage)
- [ ] Review remaining mock-heavy tests in `test_pipeline.py`
- [ ] Review `test_effects.py` for implementation detail tests
- [ ] Identify additional tests to remove/consolidate
- [ ] Target: ~600 tests total
### Phase 2: Acceptance Test Expansion (Planned)
- [ ] Create `test_message_overlay.py` for message rendering
- [ ] Create `test_firehose.py` for firehose rendering
- [ ] Create `test_pipeline_order.py` for execution order verification
- [ ] Expand `test_figment_effect.py` for animation phases
- [ ] Target: 10-15 new acceptance tests
### Phase 3: Post-Branch Features (Planned)
- [ ] Port message overlay system from `upstream_layers.py`
- [ ] Port firehose rendering from `upstream_layers.py`
- [ ] Create `MessageOverlayStage` for pipeline integration
- [ ] Verify figment renders in correct order (effects → figment → messages → display)
### Phase 4: Visual Quality Improvements (Planned)
- [ ] Compare upstream vs current pipeline output
- [ ] Implement easing functions for figment animations
- [ ] Add animated gradient shifts
- [ ] Improve strobe effect patterns
- [ ] Use introspection to match visual style
## Gitea Issues Tracking
- [#37](https://git.notsosm.art/david/Mainline/issues/37): Refactor app.py and adapter.py for better maintainability
- [#35](https://git.notsosm.art/david/Mainline/issues/35): Epic: Pipeline Mutation API for Stage Hot-Swapping