klubhaus/klubhaus-doorbell
3
0
Fork 0
Code Issues 8 Pull Requests Packages Projects Releases Wiki Activity

[MAINT] Duplicate DisplayDriverTFT code across boards #8

New Issue
Open
opened 2026-05-29 22:23:00 +00:00 by david · 0 comments
david commented 2026-05-29 22:23:00 +00:00
Owner
Copy Link
Copy Source

Problem

boards/esp32-32e/DisplayDriverTFT.cpp and boards/esp32-32e-4/DisplayDriverTFT.cpp are nearly identical (~330 lines each) with only minor differences:

  • esp32-32e-4 has transformTouch() for rotated panel
  • esp32-32e-4 has drawStatus() method
  • Font sizes differ slightly

Code duplication makes maintenance harder.

Fix

Extract common code to shared base class or template, or use build-time configuration to handle minor differences.

## Problem `boards/esp32-32e/DisplayDriverTFT.cpp` and `boards/esp32-32e-4/DisplayDriverTFT.cpp` are nearly identical (~330 lines each) with only minor differences: - esp32-32e-4 has `transformTouch()` for rotated panel - esp32-32e-4 has `drawStatus()` method - Font sizes differ slightly Code duplication makes maintenance harder. ## Fix Extract common code to shared base class or template, or use build-time configuration to handle minor differences.
david added the enhancement label 2026-05-29 22:23:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
critical
enhancement
warning
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
datapotatobaby david genewildish
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: klubhaus/klubhaus-doorbell#8
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?