klubhaus/klubhaus-doorbell
3
0
Fork 0
Code Issues 8 Pull Requests Packages Projects Releases Wiki Activity

[WARN] Inconsistent LOCAL_SECRETS handling across board configs #7

New Issue
Open
opened 2026-05-29 22:22:57 +00:00 by david · 0 comments
david commented 2026-05-29 22:22:57 +00:00
Owner
Copy Link
Copy Source

Problem

Board configs inconsistently define LOCAL_SECRETS flag:

  • esp32-32e/board-config.sh: defines LOCAL_SECRETS
  • esp32-32e-4/board-config.sh: does NOT define LOCAL_SECRETS
  • esp32-s3-lcd-43/board-config.sh: defines LOCAL_SECRETS

This inconsistency creates confusion about where secrets come from.

Affected files:

  • boards/esp32-32e/board-config.sh
  • boards/esp32-32e-4/board-config.sh
  • boards/esp32-s3-lcd-43/board-config.sh

Fix

Standardize LOCAL_SECRETS handling across all boards or document why the inconsistency exists.

## Problem Board configs inconsistently define LOCAL_SECRETS flag: - `esp32-32e/board-config.sh`: defines LOCAL_SECRETS - `esp32-32e-4/board-config.sh`: does NOT define LOCAL_SECRETS - `esp32-s3-lcd-43/board-config.sh`: defines LOCAL_SECRETS This inconsistency creates confusion about where secrets come from. **Affected files:** - `boards/esp32-32e/board-config.sh` - `boards/esp32-32e-4/board-config.sh` - `boards/esp32-s3-lcd-43/board-config.sh` ## Fix Standardize LOCAL_SECRETS handling across all boards or document why the inconsistency exists.
david added the warning label 2026-05-29 22:22:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
critical
enhancement
warning
No Label warning
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
datapotatobaby david genewildish
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: klubhaus/klubhaus-doorbell#7
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?