klubhaus/klubhaus-doorbell
3
0
Fork 0
Code Issues 8 Pull Requests Packages Projects Releases Wiki Activity

[WARN] NTPClient memory leak — never deleted #5

New Issue
Open
opened 2026-05-29 22:22:50 +00:00 by david · 0 comments
david commented 2026-05-29 22:22:50 +00:00
Owner
Copy Link
Copy Source

Problem

NetManager::NetManager() creates NTPClient* _ntp = new NTPClient(...) but never deletes it.

For long-running devices this causes a memory leak on restart.

Affected file: libraries/KlubhausCore/src/NetManager.cpp line ~39

Fix

Add destructor: ~NetManager() { delete _ntp; } or use stack allocation.

## Problem `NetManager::NetManager()` creates `NTPClient* _ntp = new NTPClient(...)` but never deletes it. For long-running devices this causes a memory leak on restart. **Affected file:** `libraries/KlubhausCore/src/NetManager.cpp` line ~39 ## Fix Add destructor: `~NetManager() { delete _ntp; }` or use stack allocation.
david added the warning label 2026-05-29 22:22:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
critical
enhancement
warning
No Label warning
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
datapotatobaby david genewildish
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: klubhaus/klubhaus-doorbell#5
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?