From 9aead397fd17f7a084ce4d0ecccf89e958e30748 Mon Sep 17 00:00:00 2001
From: David Gwilliam <dhgwilliam@gmail.com>
Date: Wed, 24 Jun 2026 02:53:16 -0700
Subject: [PATCH] fix: remove After=synth-diagnostic from pipeline services
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Root cause: synth-diagnostic uses systemctl start to start pipeline
services, but those services had After=synth-diagnostic — causing
deadlock (they waited for synth-diagnostic to exit, which was waiting
for them).

Fix: pipeline services no longer list synth-diagnostic in After=.
synth-diagnostic has Before= them for boot ordering, and starts them
directly via systemctl start in run-tests.sh.

Also fixed prometheus-exporter: had After=synth-diagnostic backwards
— should start before synth-diagnostic (synth-diagnostic has
After=prometheus-exporter).
---
 system/led-matrix-viz.service      | 2 +-
 system/midi-bridge.service         | 2 +-
 system/pd-synth-onboard.service    | 2 +-
 system/prometheus-exporter.service | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/system/led-matrix-viz.service b/system/led-matrix-viz.service
index 23e6499..3e50767 100644
--- a/system/led-matrix-viz.service
+++ b/system/led-matrix-viz.service
@@ -1,6 +1,6 @@
 [Unit]
 Description=LED Matrix MIDI Visualization
-After=arduino-router.service synth-diagnostic.service
+After=arduino-router.service
 
 [Service]
 User=arduino
diff --git a/system/midi-bridge.service b/system/midi-bridge.service
index eedc3f6..7a68d5d 100644
--- a/system/midi-bridge.service
+++ b/system/midi-bridge.service
@@ -1,6 +1,6 @@
 [Unit]
 Description=MIDI rawmidi → Pd UDP bridge (auto-detects gadget/host)
-After=multi-user.target synth-diagnostic.service
+After=multi-user.target
 
 [Service]
 Type=simple
diff --git a/system/pd-synth-onboard.service b/system/pd-synth-onboard.service
index 1a12cb5..65916da 100644
--- a/system/pd-synth-onboard.service
+++ b/system/pd-synth-onboard.service
@@ -1,6 +1,6 @@
 [Unit]
 Description=Pure Data Synth (Onboard PMIC Audio)
-After=multi-user.target synth-diagnostic.service
+After=multi-user.target
 Wants=midi-bridge.service
 
 [Service]
diff --git a/system/prometheus-exporter.service b/system/prometheus-exporter.service
index 30558fe..53d6daf 100644
--- a/system/prometheus-exporter.service
+++ b/system/prometheus-exporter.service
@@ -1,6 +1,6 @@
 [Unit]
 Description=Prometheus metrics exporter for synth pipeline
-After=multi-user.target synth-diagnostic.service
+After=multi-user.target
 
 [Service]
 Type=simple