CLI: Fix 'cd' subcommand on Windows (#16610)

The 'cd' subcommand was failing as the current shell's Windows path was
mangled while milc processed it.
Using 'subprocess' directly avoids this issue and an extra layer of
subshell.
miryoku-merge-master
Erovia 4 years ago committed by GitHub
parent 6c40b6856b
commit b75f6691a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -2,6 +2,7 @@
"""
import sys
import os
import subprocess
from milc import cli
@ -41,6 +42,6 @@ def cd(cli):
# Set the prompt for the new shell
qmk_env['MSYS2_PS1'] = qmk_env['PS1']
# Start the new subshell
cli.run([os.environ.get('SHELL', '/usr/bin/bash')], env=qmk_env)
subprocess.run([os.environ.get('SHELL', '/usr/bin/bash')], env=qmk_env)
else:
cli.log.info("Already within qmk_firmware directory.")

Loading…
Cancel
Save