david/knox
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

style: gofmt all packages (#4)

Browse Source 
Applies gofmt to the 18 files that were already unformatted at HEAD (pre-existing debt — 122 insertions / 122 deletions, whitespace plus import-block reorderings only; `git diff -w` confirms no semantic changes).

Kept on its own branch so the functional change set (see the review-hardening PR) stays reviewable without formatting noise.

Verified: go build, go vet, go test ./... pass on this branch; a merge simulation with the functional branch produces a clean 3-way merge with all tests green.
Reviewed-on: #4
Co-authored-by: David Gwilliam <dhgwilliam@gmail.com>
Co-committed-by: David Gwilliam <dhgwilliam@gmail.com>
This commit was merged in pull request #4.
This commit is contained in:
David Gwilliam
2026-09-17 09:05:57 +00:00
committed by david
parent 876d2aa45f
commit d6d2a24ddc
18 changed files with 126 additions and 126 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/cmd/browser.go
+5 -5
View File
@@ -5,9 +5,9 @@ import (
"log" "log"
"strings" "strings"
"github.com/spf13/cobra"
"github.com/david/knox/internal/db" "github.com/david/knox/internal/db"
"github.com/david/knox/internal/ingest" "github.com/david/knox/internal/ingest"
"github.com/spf13/cobra"
) )
func NewBrowserCmd(kdb *db.KnoxDB) *cobra.Command { func NewBrowserCmd(kdb *db.KnoxDB) *cobra.Command {
@@ -65,10 +65,10 @@ Run periodically to capture browsing exhaust.`,
for _, r := range results { for _, r := range results {
domains[extractDomain(r.Summary)]++ domains[extractDomain(r.Summary)]++
} }
fmt.Println("\nTop domains:") fmt.Println("\nTop domains:")
for _, d := range topDomains(domains, 10) { for _, d := range topDomains(domains, 10) {
fmt.Printf(" %-40s %d\n", d.Name, d.Count) fmt.Printf(" %-40s %d\n", d.Name, d.Count)
} }
return nil return nil
}, },
internal/cmd/gitea.go
+1 -1
View File
@@ -4,9 +4,9 @@ import (
"fmt" "fmt"
"log" "log"
"github.com/spf13/cobra"
"github.com/david/knox/internal/db" "github.com/david/knox/internal/db"
"github.com/david/knox/internal/ingest" "github.com/david/knox/internal/ingest"
"github.com/spf13/cobra"
) )
func NewGiteaCmd(kdb *db.KnoxDB) *cobra.Command { func NewGiteaCmd(kdb *db.KnoxDB) *cobra.Command {
internal/cmd/gossip.go
+1 -1
View File
@@ -3,9 +3,9 @@ package cmd
import ( import (
"fmt" "fmt"
"github.com/spf13/cobra"
"github.com/david/knox/internal/db" "github.com/david/knox/internal/db"
"github.com/david/knox/internal/watch" "github.com/david/knox/internal/watch"
"github.com/spf13/cobra"
) )
// NewGossipCmd exposes peer status/diff for the gossip protocol. // NewGossipCmd exposes peer status/diff for the gossip protocol.
internal/cmd/ingest.go
+73 -73
View File
@@ -5,10 +5,10 @@ import (
"log" "log"
"path/filepath" "path/filepath"
"github.com/spf13/cobra"
"github.com/david/knox/internal/db" "github.com/david/knox/internal/db"
"github.com/david/knox/internal/ingest" "github.com/david/knox/internal/ingest"
"github.com/david/knox/internal/watch" "github.com/david/knox/internal/watch"
"github.com/spf13/cobra"
) )
func NewIngestCmd(kdb *db.KnoxDB) *cobra.Command { func NewIngestCmd(kdb *db.KnoxDB) *cobra.Command {
@@ -27,92 +27,92 @@ func NewIngestCmd(kdb *db.KnoxDB) *cobra.Command {
ingest.NewSkillsIngester(), ingest.NewSkillsIngester(),
} }
var totalNew, totalUpdated int var totalNew, totalUpdated int
record := func(result *ingest.IngestResult) { record := func(result *ingest.IngestResult) {
_, isNew, err := kdb.RecordObservation(db.ObservationRecord{ _, isNew, err := kdb.RecordObservation(db.ObservationRecord{
Fingerprint: result.Fingerprint, Fingerprint: result.Fingerprint,
SourceID: result.SourceID, SourceID: result.SourceID,
SourcePath: result.SourcePath, SourcePath: result.SourcePath,
Project: result.Project, Project: result.Project,
ContentType: result.ContentType, ContentType: result.ContentType,
Title: result.Title, Title: result.Title,
Summary: result.Summary, Summary: result.Summary,
CreatedAt: result.CreatedAt, CreatedAt: result.CreatedAt,
LineStart: result.LineStart, LineStart: result.LineStart,
LineEnd: result.LineEnd, LineEnd: result.LineEnd,
Confidence: result.Confidence, Confidence: result.Confidence,
IngesterVersion: result.IngesterVersion, IngesterVersion: result.IngesterVersion,
Trigger: "ingest", Trigger: "ingest",
Provenance: ingest.ProvenanceJSON(result.Provenance), Provenance: ingest.ProvenanceJSON(result.Provenance),
}) })
if err != nil { if err != nil {
log.Printf("[knox] db error: %v", err) log.Printf("[knox] db error: %v", err)
return return
}
if isNew {
totalNew++
} else {
totalUpdated++
}
if result.SourceID == "opencode-session" {
sessionID, _ := result.Provenance["session_id"].(string)
if sessionID != "" {
kdb.UpsertSession(sessionID, result.Project, result.Title, "active")
} }
} if isNew {
} totalNew++
} else {
for _, ing := range ingesters { totalUpdated++
sid := ing.SourceID()
log.Printf("[knox] ingesting %s...", sid)
for _, dir := range dirs {
patterns := []string{
dir + "/*",
dir + "/*/SKILL.md",
} }
for _, pattern := range patterns {
entries, _ := filepath.Glob(pattern)
for _, path := range entries {
if !watch.MatchesIngester(path, sid) {
continue
}
result, err := ing.Ingest(path) if result.SourceID == "opencode-session" {
if err != nil || result == nil { sessionID, _ := result.Provenance["session_id"].(string)
continue if sessionID != "" {
} kdb.UpsertSession(sessionID, result.Project, result.Title, "active")
record(result)
} }
} }
} }
}
// Non-file sources: obsidian vault, browser history, gitea for _, ing := range ingesters {
if vault, err := ingest.DetectObsidianVault(); err == nil { sid := ing.SourceID()
log.Printf("[knox] ingesting obsidian...") log.Printf("[knox] ingesting %s...", sid)
if results, err := ingest.NewObsidianIngester(vault).IngestAll(); err == nil {
for _, dir := range dirs {
patterns := []string{
dir + "/*",
dir + "/*/SKILL.md",
}
for _, pattern := range patterns {
entries, _ := filepath.Glob(pattern)
for _, path := range entries {
if !watch.MatchesIngester(path, sid) {
continue
}
result, err := ing.Ingest(path)
if err != nil || result == nil {
continue
}
record(result)
}
}
}
}
// Non-file sources: obsidian vault, browser history, gitea
if vault, err := ingest.DetectObsidianVault(); err == nil {
log.Printf("[knox] ingesting obsidian...")
if results, err := ingest.NewObsidianIngester(vault).IngestAll(); err == nil {
for _, r := range results {
record(r)
}
}
}
log.Printf("[knox] ingesting browser-history...")
if results, err := ingest.NewBrowserHistoryIngester().IngestAll(); err == nil {
for _, r := range results { for _, r := range results {
record(r) record(r)
} }
} }
} log.Printf("[knox] ingesting gitea...")
log.Printf("[knox] ingesting browser-history...") if results, err := ingest.NewGiteaIngester().IngestAll(); err == nil {
if results, err := ingest.NewBrowserHistoryIngester().IngestAll(); err == nil { for _, r := range results {
for _, r := range results { record(r)
record(r) }
} }
}
log.Printf("[knox] ingesting gitea...")
if results, err := ingest.NewGiteaIngester().IngestAll(); err == nil {
for _, r := range results {
record(r)
}
}
fmt.Printf("\nIngest complete: %d new entries, %d updated\n", totalNew, totalUpdated) fmt.Printf("\nIngest complete: %d new entries, %d updated\n", totalNew, totalUpdated)
}, },
} }
cmd.Flags().StringSliceVarP(&dirs, "dir", "d", nil, "Directories to scan (default: opencode storage/log + skills)") cmd.Flags().StringSliceVarP(&dirs, "dir", "d", nil, "Directories to scan (default: opencode storage/log + skills)")
internal/cmd/obsidian.go
+1 -1
View File
@@ -4,9 +4,9 @@ import (
"fmt" "fmt"
"log" "log"
"github.com/spf13/cobra"
"github.com/david/knox/internal/db" "github.com/david/knox/internal/db"
"github.com/david/knox/internal/ingest" "github.com/david/knox/internal/ingest"
"github.com/spf13/cobra"
) )
func NewObsidianCmd(kdb *db.KnoxDB) *cobra.Command { func NewObsidianCmd(kdb *db.KnoxDB) *cobra.Command {
internal/cmd/reconcile.go
+1 -1
View File
@@ -3,9 +3,9 @@ package cmd
import ( import (
"fmt" "fmt"
"github.com/spf13/cobra"
"github.com/david/knox/internal/db" "github.com/david/knox/internal/db"
"github.com/david/knox/internal/watch" "github.com/david/knox/internal/watch"
"github.com/spf13/cobra"
) )
// NewReconcileCmd rebuilds all derived state (entries cache, threads) from the // NewReconcileCmd rebuilds all derived state (entries cache, threads) from the
internal/cmd/status.go
+1 -1
View File
@@ -6,9 +6,9 @@ import (
"os" "os"
"strings" "strings"
"github.com/spf13/cobra"
"github.com/david/knox/internal/db" "github.com/david/knox/internal/db"
"github.com/david/knox/internal/index" "github.com/david/knox/internal/index"
"github.com/spf13/cobra"
) )
func paginate(entries []db.Entry, page, limit int) []db.Entry { func paginate(entries []db.Entry, page, limit int) []db.Entry {
internal/cmd/topics.go
+1 -1
View File
@@ -5,9 +5,9 @@ import (
"regexp" "regexp"
"strings" "strings"
"github.com/spf13/cobra"
"github.com/david/knox/internal/db" "github.com/david/knox/internal/db"
"github.com/david/knox/internal/index" "github.com/david/knox/internal/index"
"github.com/spf13/cobra"
) )
func NewTopicsCmd(kdb *db.KnoxDB) *cobra.Command { func NewTopicsCmd(kdb *db.KnoxDB) *cobra.Command {
internal/cmd/watch.go
+1 -1
View File
@@ -4,9 +4,9 @@ import (
"io" "io"
"log" "log"
"github.com/spf13/cobra"
"github.com/david/knox/internal/db" "github.com/david/knox/internal/db"
"github.com/david/knox/internal/watch" "github.com/david/knox/internal/watch"
"github.com/spf13/cobra"
) )
func NewWatchCmd(kdb *db.KnoxDB) *cobra.Command { func NewWatchCmd(kdb *db.KnoxDB) *cobra.Command {
internal/db/metrics.go
+1 -1
View File
@@ -11,7 +11,7 @@ type MetricsSnapshot struct {
PendingReflections int PendingReflections int
ThreadsByStatus map[string]int ThreadsByStatus map[string]int
Peers int Peers int
ByOriginNode map[string]int // node_id → observation count ByOriginNode map[string]int // node_id → observation count
KnowledgeVector map[string]int64 // node_id → max hcl KnowledgeVector map[string]int64 // node_id → max hcl
EarliestObservation string EarliestObservation string
} }
internal/metrics/metrics.go
+15 -15
View File
@@ -19,23 +19,23 @@ import (
// scrape-time gauges derived from the database (refreshed on each scrape). // scrape-time gauges derived from the database (refreshed on each scrape).
type Metrics struct { type Metrics struct {
// Gossip counters (live). // Gossip counters (live).
pullsTotal prometheus.Counter pullsTotal prometheus.Counter
pushesTotal prometheus.Counter pushesTotal prometheus.Counter
obsPulledTotal prometheus.Counter obsPulledTotal prometheus.Counter
obsPushedTotal prometheus.Counter obsPushedTotal prometheus.Counter
errorsTotal prometheus.Counter errorsTotal prometheus.Counter
// Snapshot gauges (updated per scrape). // Snapshot gauges (updated per scrape).
observationsGauge *prometheus.GaugeVec observationsGauge *prometheus.GaugeVec
entriesGauge prometheus.Gauge entriesGauge prometheus.Gauge
projectsGauge prometheus.Gauge projectsGauge prometheus.Gauge
sessionsGauge prometheus.Gauge sessionsGauge prometheus.Gauge
pendingReflections prometheus.Gauge pendingReflections prometheus.Gauge
peersGauge prometheus.Gauge peersGauge prometheus.Gauge
threadsByStatus *prometheus.GaugeVec threadsByStatus *prometheus.GaugeVec
byOriginNode *prometheus.GaugeVec byOriginNode *prometheus.GaugeVec
knowledgeVector *prometheus.GaugeVec knowledgeVector *prometheus.GaugeVec
observationsLast24h prometheus.Gauge observationsLast24h prometheus.Gauge
registry *prometheus.Registry registry *prometheus.Registry
kdb *db.KnoxDB kdb *db.KnoxDB
internal/watch/gossip.go
+13 -13
View File
@@ -33,11 +33,11 @@ type Node struct {
// pingResponse is the anti-entropy summary returned by /v1/ping. // pingResponse is the anti-entropy summary returned by /v1/ping.
type pingResponse struct { type pingResponse struct {
NodeID string `json:"node_id"` NodeID string `json:"node_id"`
Name string `json:"name"` Name string `json:"name"`
Vector map[string]int64 `json:"vector"` // node_id → max hcl Vector map[string]int64 `json:"vector"` // node_id → max hcl
Peers []db.PeerInfo `json:"peers"` // swarm membership this node knows Peers []db.PeerInfo `json:"peers"` // swarm membership this node knows
MaxHCL *int64 `json:"max_hcl,omitempty"` MaxHCL *int64 `json:"max_hcl,omitempty"`
} }
func (n *Node) Handler() http.Handler { func (n *Node) Handler() http.Handler {
@@ -123,11 +123,11 @@ func (n *Node) handleBatch(w http.ResponseWriter, r *http.Request) {
// DiffSummary is the divergence snapshot served at /v1/diff: everything this // DiffSummary is the divergence snapshot served at /v1/diff: everything this
// node observes, plus the status of auto-threaded threads (for tombstones). // node observes, plus the status of auto-threaded threads (for tombstones).
type DiffSummary struct { type DiffSummary struct {
NodeID string `json:"node_id"` NodeID string `json:"node_id"`
Name string `json:"name"` Name string `json:"name"`
Fingerprints []string `json:"fingerprints"` Fingerprints []string `json:"fingerprints"`
ThreadStatus map[string]string `json:"thread_status"` ThreadStatus map[string]string `json:"thread_status"`
ObsCount int `json:"obs_count"` ObsCount int `json:"obs_count"`
} }
func (n *Node) handleDiff(w http.ResponseWriter, r *http.Request) { func (n *Node) handleDiff(w http.ResponseWriter, r *http.Request) {
@@ -163,9 +163,9 @@ func writeJSON(w http.ResponseWriter, v any) {
// Client is the pull/push half used by the exchange loop. // Client is the pull/push half used by the exchange loop.
type Client struct { type Client struct {
NodeID string NodeID string
Addr string Addr string
Timeout time.Duration Timeout time.Duration
} }
func (c *Client) Ping() (*pingResponse, error) { func (c *Client) Ping() (*pingResponse, error) {
main.go
+2 -2
View File
@@ -5,11 +5,11 @@ import (
"log" "log"
"os" "os"
mcpServer "github.com/mark3labs/mcp-go/server"
"github.com/spf13/cobra"
knoxcmd "github.com/david/knox/internal/cmd" knoxcmd "github.com/david/knox/internal/cmd"
"github.com/david/knox/internal/db" "github.com/david/knox/internal/db"
knoxserver "github.com/david/knox/internal/server" knoxserver "github.com/david/knox/internal/server"
mcpServer "github.com/mark3labs/mcp-go/server"
"github.com/spf13/cobra"
) )
func newServeCmd(kdb *db.KnoxDB) *cobra.Command { func newServeCmd(kdb *db.KnoxDB) *cobra.Command {