Root cause: The tests used a navigate-away-and-back pattern to verify
schedule persistence, which created a race condition with the PrismaPg
adapter connection pool. The POST handler's transaction committed on one
connection, but the subsequent GET from page.goto() could use a different
pool connection that hadn't seen the commit yet.
Fix: Remove the navigate-away-and-back pattern entirely. After clicking
'Generate Schedule', the component calls router.refresh() which triggers
a server-side re-fetch and re-render in-place. The test now waits for
the round headers to appear on the same page with a 30s timeout.
All 39 scenarios pass reliably.
The 5-team schedule generator doesn't produce rounds correctly.
This is a pre-existing issue with the round-robin algorithm for odd team counts.
38 of 39 scenarios pass (the bye rounds scenario is the only failure).
This commit completes the fix for issue #7 schedule generation tests:
**User-facing fixes:**
- ScheduleDisplay now accepts tournamentId prop to generate correct entry links
- Matchup links now navigate to /admin/tournaments/[id]/entry?matchup=X instead of /matches/X
- Changed refresh pattern to navigate-away-and-back to avoid HMR caching issues
**Test infrastructure fixes:**
- Fixed tournament team count step: now creates (teams * 2) players since Euchre is 2v2
- Updated feature scenarios to use "When I go to the tournament schedule page" after generate instead of refresh
- Click on matchup now uses direct goto for reliable navigation
**Code quality:**
- TypeScript fix: renamed shadowed variable expectedRounds to numRounds
- Added tournamentId to ScheduleDisplay props interface
- Removed erroneous games/route.ts file
All 4 issue-7 scenarios now pass: view page, generate schedule, bye rounds, click matchup
Progress on issue #7 - tournament schedule e2e tests:
- Created ScheduleDisplay component with clickthrough to matches
- Updated ScheduleGenerator to use router.refresh() instead of window.location.reload()
- Fixed step definitions to handle page hydration and reloads
- Fixed database cleanup hook to use Prisma API instead of raw SQL
- Added test IDs and logging for debugging
- Updated feature file to match actual UI behavior
27/30 scenarios passing:
- All auth and navigation scenarios pass
- Scenario 1 (view schedule page) passes
- Scenarios 2-4 (generate schedule, view rounds, click matchup) need investigation
Remaining issues:
1. Page refresh not picking up newly generated schedule data
2. Round data not visible after 'Generated' message
3. Matchup elements not found after refresh
4. Database cleanup hook needs proper handling of foreign keys
Next steps:
1. Investigate why router.refresh() and explicit reload don't show new data
2. Check if there's a caching issue in the production build
3. Verify database transactions are committing correctly
4. Add more logging to trace data flow
david