refactor: improve test structure for Bun compatibility

- Update all test files to use named mock variables instead of inline mocks
- Clear mock history in beforeEach instead of using mock.restore()
- Add default mock implementations stored at module level
- Document that tests should not use --randomize flag due to mock.module() limitations
- All 89 unit tests pass consistently without randomization

src/__tests__/unit/tournament-update.test.ts

@@ -3,23 +3,33 @@
  * Tests the allowTies field is properly saved when updating tournaments
  */
 
-import { describe, it, expect, mock, beforeEach } from 'bun:test';
+import { describe, it, expect, mock, beforeEach,} from 'bun:test';
 import { prisma } from '@/lib/prisma';
 
+// Create mock functions at module level
+const eventFindUniqueMock = mock(() => {});
+const eventUpdateMock = mock(() => {});
+const canManageTournamentMock = mock(() => {});
+const canDeleteTournamentMock = mock(() => {});
+
+// Store default implementations
+const defaultCanManageTournament = canManageTournamentMock.mockResolvedValue({ allowed: true });
+const defaultCanDeleteTournament = canDeleteTournamentMock.mockResolvedValue({ allowed: true });
+
 // Mock the prisma client
 mock.module('@/lib/prisma', () => ({
   prisma: {
     event: {
-      findUnique: mock(() => {}),
-      update: mock(() => {}),
+      findUnique: eventFindUniqueMock,
+      update: eventUpdateMock,
     },
   },
 }));
 
 // Mock the permissions module
 mock.module('@/lib/permissions', () => ({
-  canManageTournament: mock(() => {}).mockResolvedValue({ allowed: true }),
-  canDeleteTournament: mock(() => {}).mockResolvedValue({ allowed: true }),
+  canManageTournament: defaultCanManageTournament,
+  canDeleteTournament: defaultCanDeleteTournament,
 }));
 
 // Import the route handler after mocking
@@ -27,12 +37,16 @@ import { PUT } from '@/app/api/tournaments/[id]/route';
 
 describe('Tournament Update API', () => {
   beforeEach(() => {
-    mock.clearAllMocks();
+    // Clear all mock history before each test
+    eventFindUniqueMock.mockClear();
+    eventUpdateMock.mockClear();
+    canManageTournamentMock.mockClear();
+    canDeleteTournamentMock.mockClear();
   });
 
   it('should update allowTies field when provided', async () => {
     // Mock existing tournament
-    prisma.event.findUnique.mockImplementation(async () => ({
+    eventFindUniqueMock.mockImplementation(async () => ({
       id: 1,
       name: 'Test Tournament',
       allowTies: false,
@@ -49,7 +63,7 @@ describe('Tournament Update API', () => {
       } as any));
 
     // Mock successful update
-    prisma.event.update.mockImplementation(async () => ({
+    eventUpdateMock.mockImplementation(async () => ({
       id: 1,
       name: 'Test Tournament',
       allowTies: true,
@@ -89,7 +103,7 @@ describe('Tournament Update API', () => {
 
   it('should default allowTies to false when not provided', async () => {
     // Mock existing tournament
-    prisma.event.findUnique.mockImplementation(async () => ({
+    eventFindUniqueMock.mockImplementation(async () => ({
       id: 1,
       name: 'Test Tournament',
       allowTies: true,
@@ -106,7 +120,7 @@ describe('Tournament Update API', () => {
       } as any));
 
     // Mock successful update
-    prisma.event.update.mockImplementation(async () => ({
+    eventUpdateMock.mockImplementation(async () => ({
       id: 1,
       name: 'Test Tournament',
       allowTies: false,
@@ -146,7 +160,7 @@ describe('Tournament Update API', () => {
 
   it('should preserve allowTies value when updating other fields', async () => {
     // Mock existing tournament with allowTies = true
-    prisma.event.findUnique.mockImplementation(async () => ({
+    eventFindUniqueMock.mockImplementation(async () => ({
       id: 1,
       name: 'Test Tournament',
       allowTies: true,
@@ -163,7 +177,7 @@ describe('Tournament Update API', () => {
       } as any));
 
     // Mock successful update
-    prisma.event.update.mockImplementation(async () => ({
+    eventUpdateMock.mockImplementation(async () => ({
       id: 1,
       name: 'Updated Tournament Name',
       allowTies: true,
@@ -192,7 +206,7 @@ describe('Tournament Update API', () => {
     const response = await PUT(request, { params });
 
     expect(response.status).toBe(200);
-    const updateCall = prisma.event.update.mock.calls[0][0];
+    const updateCall = eventUpdateMock.mock.calls[0][0];
     expect(updateCall.data.allowTies).toBe(true);
     expect(updateCall.data.name).toBe('Updated Tournament Name');
     expect(updateCall.data.targetScore).toBe(10);