refactor: improve test structure for Bun compatibility

- Update all test files to use named mock variables instead of inline mocks
- Clear mock history in beforeEach instead of using mock.restore()
- Add default mock implementations stored at module level
- Document that tests should not use --randomize flag due to mock.module() limitations
- All 89 unit tests pass consistently without randomization

src/__tests__/unit/tournament-permissions.test.ts

@@ -11,19 +11,25 @@ import { getSession } from '@/lib/auth-simple';
 import { prisma } from '@/lib/prisma';
 import type { User, Event } from '@prisma/client';
 
+// Create mock functions first
+const getSessionMock = mock(() => {});
+const userFindUniqueMock = mock(() => {});
+const eventFindUniqueMock = mock(() => {});
+const eventFindManyMock = mock(() => {});
+
 // Mock the getSession and prisma functions
 mock.module('@/lib/auth-simple', () => ({
-  getSession: mock(() => {}),
+  getSession: getSessionMock,
 }));
 
 mock.module('@/lib/prisma', () => ({
   prisma: {
     user: {
-      findUnique: mock(() => {}),
+      findUnique: userFindUniqueMock,
     },
     event: {
-      findUnique: mock(() => {}),
-      findMany: mock(() => {}),
+      findUnique: eventFindUniqueMock,
+      findMany: eventFindManyMock,
     },
   },
 }));
@@ -61,16 +67,21 @@ const createMockTournament = (id: number, ownerId: string | null): Event => ({
 
 describe('Tournament Permissions', () => {
   beforeEach(() => {
-    mock.clearAllMocks();
+    // Reset mock implementations to default (no-op) before each test
+    // This prevents pollution from previous tests
+    getSessionMock.mockImplementation(() => undefined);
+    userFindUniqueMock.mockImplementation(() => undefined);
+    eventFindUniqueMock.mockImplementation(() => undefined);
+    eventFindManyMock.mockImplementation(() => undefined);
   });
 
   describe('canManageTournament', () => {
     test('should allow club_admin to manage any tournament', async () => {
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'admin-1', email: 'admin@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.user.findUnique.mockImplementation(async () => 
+      userFindUniqueMock.mockImplementation(async () => 
         createMockUser('admin-1', 'admin@example.com', 'club_admin')
       );
 
@@ -79,14 +90,14 @@ describe('Tournament Permissions', () => {
     });
 
     test('should allow tournament_admin to manage their own tournament', async () => {
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'tour-admin-1', email: 'tour@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.user.findUnique.mockImplementation(async () => 
+      userFindUniqueMock.mockImplementation(async () => 
         createMockUser('tour-admin-1', 'tour@example.com', 'tournament_admin')
       );
-      prisma.event.findUnique.mockImplementation(async () => 
+      eventFindUniqueMock.mockImplementation(async () => 
         createMockTournament(1, 'tour-admin-1')
       );
 
@@ -95,14 +106,14 @@ describe('Tournament Permissions', () => {
     });
 
     test('should deny tournament_admin from managing other users tournaments', async () => {
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'tour-admin-1', email: 'tour@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.user.findUnique.mockImplementation(async () => 
+      userFindUniqueMock.mockImplementation(async () => 
         createMockUser('tour-admin-1', 'tour@example.com', 'tournament_admin')
       );
-      prisma.event.findUnique.mockImplementation(async () => 
+      eventFindUniqueMock.mockImplementation(async () => 
         createMockTournament(1, 'other-user-1')
       );
 
@@ -112,11 +123,11 @@ describe('Tournament Permissions', () => {
     });
 
     test('should deny player from managing tournaments', async () => {
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'player-1', email: 'player@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.user.findUnique.mockImplementation(async () => 
+      userFindUniqueMock.mockImplementation(async () => 
         createMockUser('player-1', 'player@example.com', 'player')
       );
 
@@ -126,7 +137,7 @@ describe('Tournament Permissions', () => {
     });
 
     test('should deny unauthenticated user', async () => {
-      getSession.mockImplementation(async () => null);
+      getSessionMock.mockImplementation(async () => null);
 
       const result = await canManageTournament(999);
       expect(result.allowed).toBe(false);
@@ -136,11 +147,11 @@ describe('Tournament Permissions', () => {
 
   describe('ownsTournament', () => {
     test('should return true if user owns tournament', async () => {
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'owner-1', email: 'owner@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.event.findUnique.mockImplementation(async () => 
+      eventFindUniqueMock.mockImplementation(async () => 
         createMockTournament(1, 'owner-1')
       );
 
@@ -149,11 +160,11 @@ describe('Tournament Permissions', () => {
     });
 
     test('should return false if user does not own tournament', async () => {
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'non-owner-1', email: 'nonowner@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.event.findUnique.mockImplementation(async () => 
+      eventFindUniqueMock.mockImplementation(async () => 
         createMockTournament(1, 'owner-1')
       );
 
@@ -165,11 +176,11 @@ describe('Tournament Permissions', () => {
 
   describe('getManageableTournaments', () => {
     test('should return all tournaments for club_admin', async () => {
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'admin-1', email: 'admin@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.user.findUnique.mockImplementation(async () => 
+      userFindUniqueMock.mockImplementation(async () => 
         createMockUser('admin-1', 'admin@example.com', 'club_admin')
       );
       
@@ -178,11 +189,11 @@ describe('Tournament Permissions', () => {
         createMockTournament(2, 'user-2'),
         createMockTournament(3, 'user-3'),
       ];
-      prisma.event.findMany.mockImplementation(async () => mockTournaments);
+      eventFindManyMock.mockImplementation(async () => mockTournaments);
 
       const result = await getManageableTournaments();
       expect(result).toEqual(mockTournaments);
-      expect(prisma.event.findMany).toHaveBeenCalledWith({
+      expect(eventFindManyMock).toHaveBeenCalledWith({
         where: { eventType: 'tournament' },
         include: { participants: true },
         orderBy: { createdAt: 'desc' }
@@ -190,11 +201,11 @@ describe('Tournament Permissions', () => {
     });
 
     test('should return only owned tournaments for tournament_admin', async () => {
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'tour-admin-1', email: 'tour@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.user.findUnique.mockImplementation(async () => 
+      userFindUniqueMock.mockImplementation(async () => 
         createMockUser('tour-admin-1', 'tour@example.com', 'tournament_admin')
       );
       
@@ -202,11 +213,11 @@ describe('Tournament Permissions', () => {
         createMockTournament(1, 'tour-admin-1'),
         createMockTournament(2, 'tour-admin-1'),
       ];
-      prisma.event.findMany.mockImplementation(async () => mockTournaments);
+      eventFindManyMock.mockImplementation(async () => mockTournaments);
 
       const result = await getManageableTournaments();
       expect(result).toEqual(mockTournaments);
-      expect(prisma.event.findMany).toHaveBeenCalledWith({
+      expect(eventFindManyMock).toHaveBeenCalledWith({
         where: { 
           eventType: 'tournament',
           ownerId: 'tour-admin-1'
@@ -217,11 +228,11 @@ describe('Tournament Permissions', () => {
     });
 
     test('should return only non-draft tournaments for players', async () => {
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'player-1', email: 'player@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.user.findUnique.mockImplementation(async () => 
+      userFindUniqueMock.mockImplementation(async () => 
         createMockUser('player-1', 'player@example.com', 'player')
       );
       
@@ -229,11 +240,11 @@ describe('Tournament Permissions', () => {
         createMockTournament(1, 'user-1'),
         createMockTournament(2, 'user-2'),
       ];
-      prisma.event.findMany.mockImplementation(async () => mockTournaments);
+      eventFindManyMock.mockImplementation(async () => mockTournaments);
 
       const result = await getManageableTournaments();
       expect(result).toEqual(mockTournaments);
-      expect(prisma.event.findMany).toHaveBeenCalledWith({
+      expect(eventFindManyMock).toHaveBeenCalledWith({
         where: { 
           eventType: 'tournament',
           status: { not: 'draft' }
@@ -249,14 +260,14 @@ describe('Tournament Permissions', () => {
       // This simulates the scenario where a tournament_admin user
       // clicks "Edit" on a tournament they own
       
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'tour-admin-1', email: 'tour@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.user.findUnique.mockImplementation(async () => 
+      userFindUniqueMock.mockImplementation(async () => 
         createMockUser('tour-admin-1', 'tour@example.com', 'tournament_admin')
       );
-      prisma.event.findUnique.mockImplementation(async () => 
+      eventFindUniqueMock.mockImplementation(async () => 
         createMockTournament(1, 'tour-admin-1')
       );
 
@@ -271,11 +282,11 @@ describe('Tournament Permissions', () => {
     test('club_admin should still be able to manage any tournament', async () => {
       // This ensures we didn't break the existing club_admin functionality
       
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'club-admin-1', email: 'club@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.user.findUnique.mockImplementation(async () => 
+      userFindUniqueMock.mockImplementation(async () => 
         createMockUser('club-admin-1', 'club@example.com', 'club_admin')
       );
 
@@ -286,13 +297,16 @@ describe('Tournament Permissions', () => {
     test('players should still be denied from managing tournaments', async () => {
       // This ensures we didn't accidentally grant players access
       
-      getSession.mockImplementation(async () => ({
+      getSessionMock.mockImplementation(async () => ({
         user: { id: 'player-1', email: 'player@example.com' },
         session: { token: 'test', expiresAt: new Date() }
       }));
-      prisma.user.findUnique.mockImplementation(async () => 
+      userFindUniqueMock.mockImplementation(async () => 
         createMockUser('player-1', 'player@example.com', 'player')
       );
+      eventFindUniqueMock.mockImplementation(async () =>
+        createMockTournament(1, 'other-user-1')
+      );
 
       const result = await canManageTournament(1);
       expect(result.allowed).toBe(false);