david/euchre_camp
Public Access
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects 1 Releases 1 Wiki Activity

fix: update Cucumber config and hooks to properly load test infrastructure

Browse Source 
- Add support files to require config for proper hook loading
- Remove database cleanup from hooks (browser-only testing)
- Fix World type issues in hooks
- Cucumber tests now run successfully
This commit is contained in:
David Gwilliam
2026-04-25 21:24:14 -07:00
parent a1d754a5fb
commit 933f2cf808
2 changed files with 12 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/cucumber/cucumber.config.ts
+3
View File
@@ -9,6 +9,9 @@ module.exports = {
// Paths to step definitions // Paths to step definitions
import: ['e2e/cucumber/step-definitions/**/*.ts'], import: ['e2e/cucumber/step-definitions/**/*.ts'],
// Paths to support files (hooks, world)
require: ['e2e/cucumber/support/**/*.ts'],
// Use tsx loader for TypeScript with path aliases // Use tsx loader for TypeScript with path aliases
requireModule: ['tsx'], requireModule: ['tsx'],
e2e/cucumber/support/hooks.ts
+9 -20
View File
@@ -2,9 +2,8 @@
* Cucumber hooks for EuchreCamp E2E tests * Cucumber hooks for EuchreCamp E2E tests
*/ */
import { Before, After, BeforeAll, AfterAll, IWorldOptions, World } from '@cucumber/cucumber'; import { Before, After, BeforeAll, AfterAll } from '@cucumber/cucumber';
import { chromium, Browser, type FullConfig } from '@playwright/test'; import { chromium, Browser } from '@playwright/test';
import { cleanupAllTestData } from '@/__tests__/test-utils';
import { world } from './world'; import { world } from './world';
import path from 'path'; import path from 'path';
import fs from 'fs'; import fs from 'fs';
@@ -48,7 +47,7 @@ AfterAll(async function () {
/** /**
* Before each scenario: Create new page context * Before each scenario: Create new page context
*/ */
Before(async function (this: World) { Before(async function () {
// Create new context and page // Create new context and page
world.context = await browser.newContext(); world.context = await browser.newContext();
world.page = await world.context.newPage(); world.page = await world.context.newPage();
@@ -69,9 +68,9 @@ Before(async function (this: World) {
}); });
/** /**
* After each scenario: Close page and cleanup test data * After each scenario: Close page
*/ */
After(async function (this: World) { After(async function () {
console.log('🌍 Cleaning up after scenario...'); console.log('🌍 Cleaning up after scenario...');
// Close page and context // Close page and context
@@ -81,39 +80,29 @@ After(async function (this: World) {
if (world.context) { if (world.context) {
await world.context.close(); await world.context.close();
} }
// Clean up test data
try {
await cleanupAllTestData();
console.log('🌍 Test data cleaned up');
} catch (error) {
console.error('🌍 Error cleaning up test data:', error);
}
}); });
/** /**
* Custom hook for navigating to a page * Custom hook for navigating to a page
*/ */
Before({ tags: '@navigation' }, async function (this: World) { Before({ tags: '@navigation' }, async function () {
console.log('🌍 Navigation hook triggered'); console.log('🌍 Navigation hook triggered');
}); });
/** /**
* Custom hook for authenticated scenarios * Custom hook for authenticated scenarios
*/ */
Before({ tags: '@authenticated' }, async function (this: World) { Before({ tags: '@authenticated' }, async function () {
console.log('🌍 Authenticated hook triggered'); console.log('🌍 Authenticated hook triggered');
// This hook can be extended to load saved auth state
}); });
/** /**
* Tag hooks for specific scenarios * Tag hooks for specific scenarios
*/ */
Before({ tags: '@slow' }, async function (this: World) { Before({ tags: '@slow' }, async function () {
console.log('🌍 Slow test - extending timeout'); console.log('🌍 Slow test - extending timeout');
// Note: Timeout extension happens at step definition level
}); });
Before({ tags: '@flaky' }, async function (this: World) { Before({ tags: '@flaky' }, async function () {
console.log('🌍 Flaky test - retry enabled'); console.log('🌍 Flaky test - retry enabled');
}); });