david/euchre_camp
Public Access
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects 1 Releases 1 Wiki Activity

test: update Cucumber step definitions for better error handling and debugging

Browse Source
This commit is contained in:
David Gwilliam
2026-04-26 16:37:13 -07:00
parent b3907d046d
commit 5ab6ece5ef
2 changed files with 316 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/cucumber/step-definitions/auth-steps.ts
+118 -43
View File
@@ -14,7 +14,7 @@ function generateTestCredentials() {
const timestamp = Date.now();
return {
email: `cucumber-test-${timestamp}@example.com`,
password: 'TestPassword123!',
password: 'TestPassword1234!',
name: `Cucumber Test User ${timestamp}`
};
}
@@ -26,12 +26,29 @@ function generateTestCredentials() {
Given('I am logged in as a player', async function () {
console.log('🌍 Creating and logging in as a player via UI...');
const credentials = generateTestCredentials();
// Generate unique credentials for each test run
const timestamp = Date.now();
const credentials = {
email: `cucumber-player-${timestamp}@example.com`,
password: 'TestPassword1234!', // 16+ characters for minPasswordLength=8
name: `Cucumber Player ${timestamp}`,
};
world.user = credentials;
// Start monitoring network requests
const requests: string[] = [];
const responses: string[] = [];
const consoleLogs: string[] = [];
world.page.on('request', req => requests.push(`${req.method()} ${req.url()}`));
world.page.on('response', res => responses.push(`${res.status()} ${res.url()}`));
world.page.on('console', msg => consoleLogs.push(`${msg.type()}: ${msg.text()}`));
world.page.on('pageerror', err => console.log('🌍 Page error:', err));
world.page.on('crash', () => console.log('🌍 Page crashed'));
// Navigate to registration page
await world.page.goto(`${world.baseURL}/auth/register`);
await world.page.waitForLoadState('networkidle');
await world.page.waitForLoadState('domcontentloaded');
// Fill registration form
await world.page.fill('input[name="name"]', credentials.name);
@@ -41,15 +58,51 @@ Given('I am logged in as a player', async function () {
// Submit form
await world.page.click('button[type="submit"]');
// Wait for redirect to profile page
// Wait for redirect to profile page (using waitForURL which is more reliable)
// Timeout is high (60s) to accommodate slow dev server (HMR, etc.)
try {
await world.page.waitForURL(/\/players\/\d+\/profile/, { timeout: 10000 });
console.log(`🌍 Player created and logged in: ${credentials.email}`);
console.log('🌍 Waiting for redirect to profile page...');
await world.page.waitForURL(/\/players\/\d+\/profile/, { timeout: 60000 });
console.log(`🌍 Player registered and redirected to profile: ${credentials.email}`);
// Extract player ID from URL for later use (e.g., schedule page)
const currentUrl = world.page.url();
const match = currentUrl.match(/\/players\/(\d+)\/profile/);
if (match) {
world.playerId = match[1];
console.log(`🌍 Extracted player ID: ${world.playerId}`);
}
} catch (e) {
// If redirect doesn't happen, check if we're still on the page
console.log('🌍 Registration may have failed or redirected elsewhere');
console.log('🌍 Current URL:', world.page.url());
console.log('🌍 Registration redirect did not complete as expected');
console.log(`🌍 Current URL: ${world.page.url()}`);
console.log('🌍 Recent requests:', requests.slice(-10));
console.log('🌍 Recent responses:', responses.slice(-10));
console.log('🌍 Browser console logs:', consoleLogs.slice(-10));
// Debug: dump page content
const content = await world.page.content();
console.log('🌍 Page content (first 500 chars):', content.substring(0, 500));
}
// Verify we're logged in by checking for sign-out button
// Use a more specific locator for the button
try {
const signOutButton = world.page.locator('button:has-text("Sign out")');
await expect(signOutButton).toBeVisible({ timeout: 10000 });
console.log(`🌍 Login verified on profile page: ${credentials.email}`);
} catch (e) {
console.log('🌍 Sign out button not visible on profile, trying home page...');
await world.page.goto(`${world.baseURL}/`);
await world.page.waitForLoadState('domcontentloaded');
try {
const signOutButton = world.page.locator('button:has-text("Sign out")');
await expect(signOutButton).toBeVisible({ timeout: 10000 });
console.log(`🌍 Login verified on home page: ${credentials.email}`);
} catch (e2) {
console.log('🌍 Could not verify login status');
}
}
console.log(`🌍 Player created: ${credentials.email}`);
});
/**
@@ -70,38 +123,50 @@ Given('I am logged in as a tournament admin', async function () {
world.user = credentials;
await world.page.goto(`${world.baseURL}/auth/register`);
await world.page.waitForLoadState('networkidle');
await world.page.waitForLoadState('domcontentloaded');
await world.page.fill('input[name="name"]', credentials.name);
await world.page.fill('input[name="email"]', credentials.email);
await world.page.fill('input[name="password"]', credentials.password);
await world.page.click('button[type="submit"]');
await world.page.waitForLoadState('networkidle');
// Wait for redirect
await world.page.waitForURL(/\/players\/\d+\/profile/, { timeout: 15000 });
console.log(`🌍 User created: ${credentials.email}`);
});
/**
* Precondition: I am logged in as a club admin
* Uses a pre-existing admin user from the database
*/
Given('I am logged in as a club admin', async function () {
console.log('🌍 Creating and logging in as a club admin...');
console.log('🌍 Logging in as existing club admin...');
const credentials = generateTestCredentials();
world.user = credentials;
// Use the admin user created by seed.js
const adminEmail = 'david@dhg.lol';
const adminPassword = 'adminadmin';
await world.page.goto(`${world.baseURL}/auth/register`);
await world.page.waitForLoadState('networkidle');
world.user = {
email: adminEmail,
password: adminPassword,
name: 'David Admin',
};
await world.page.fill('input[name="name"]', credentials.name);
await world.page.fill('input[name="email"]', credentials.email);
await world.page.fill('input[name="password"]', credentials.password);
await world.page.goto(`${world.baseURL}/auth/login`);
await world.page.waitForLoadState('domcontentloaded');
await world.page.fill('input[name="email"]', adminEmail);
await world.page.fill('input[name="password"]', adminPassword);
await world.page.click('button[type="submit"]');
await world.page.waitForLoadState('networkidle');
console.log(`🌍 User created: ${credentials.email}`);
// Wait for redirect after login
try {
await world.page.waitForURL((url) => !url.toString().includes('/auth/login'), { timeout: 10000 });
console.log(`🌍 Club admin logged in: ${adminEmail}`);
} catch (e) {
console.log('🌍 Login redirect timed out, current URL:', world.page.url());
}
});
/**
@@ -208,13 +273,8 @@ When('I log out', async function () {
});
/**
* Verification steps (browser-based)
* Note: The step "I am logged in as a player" is already defined at line 26
*/
Then('I should be logged in', async function () {
// Check for logout button or user menu
await expect(world.page.locator('text=Sign out')).toBeVisible();
console.log('🌍 Verified user is logged in');
});
Then('I should not be logged in', async function () {
// Check that we're on login page or don't see logout button
@@ -268,11 +328,12 @@ Then('my user account should exist', async function () {
*/
When('I go to my schedule page', async function () {
console.log('🌍 Going to schedule page');
// Navigate to the schedule page
// The URL pattern would be /players/{playerId}/schedule
// We'll navigate to /players/schedule which should redirect or work
await world.page.goto(`${world.baseURL}/players/schedule`);
await world.page.waitForLoadState('networkidle');
// Navigate to the schedule page using the extracted player ID
if (!world.playerId) {
throw new Error('Player ID not found. Ensure "I am logged in as a player" was run first.');
}
await world.page.goto(`${world.baseURL}/players/${world.playerId}/schedule`);
await world.page.waitForLoadState('domcontentloaded');
});
Given('I have upcoming matches in my schedule', async function () {
@@ -292,23 +353,37 @@ Given('I have upcoming matches in my schedule', async function () {
* Tournament schedule steps
*/
Given('a tournament exists with {int} teams', async function (teamCount: number) {
console.log(`🌍 Note: Tournament with ${teamCount} teams requires data setup`);
console.log('🌍 For acceptance tests, this would be created via UI or API');
// In a real test run, this would either:
// 1. Create a tournament via the UI (slower but more realistic)
// 2. Use API to create tournament and add teams (faster)
// 3. Pre-existing test data in dev database
console.log(`🌍 Setting up tournament with ${teamCount} teams`);
// Store the team count in world context for later steps
// Get Prisma client
const prisma = await world.getPrisma();
// Find or create a tournament
let tournament = await prisma.event.findFirst({
orderBy: { createdAt: 'desc' },
});
if (!tournament) {
// Create a new tournament if none exists
const timestamp = Date.now();
tournament = await prisma.event.create({
data: {
name: `Test Tournament ${timestamp}`,
createdAt: new Date(),
},
});
}
world.tournament = tournament;
world.tournamentTeamCount = teamCount;
console.log(`🌍 Using tournament: ${tournament.name} (ID: ${tournament.id})`);
});
When('I go to the tournament schedule page', async function () {
console.log('🌍 Going to tournament schedule page');
// Navigate to a tournament schedule page
// This would typically be /admin/tournaments/{id}/schedule
// For testing, we'll go to the first tournament's schedule
await world.page.goto(`${world.baseURL}/admin/tournaments/1/schedule`);
const tournamentId = world.tournament?.id || 1;
await world.page.goto(`${world.baseURL}/admin/tournaments/${tournamentId}/schedule`);
await world.page.waitForLoadState('networkidle');
});