fix: resolve remaining TypeScript and linting errors

- Fixed unused variables in unit tests (elo.test.ts, permissions.test.ts)
- Fixed unused variables in E2E tests (account-acceptance.test.ts, elo-ratings.test.ts, epic1-auth-registration.test.ts, global.setup.ts)
- Fixed 'any' type usage in EditTournamentForm.test.tsx and auth-simple.test.ts
- Fixed unescaped quotes and apostrophes in React components
- Fixed TypeScript type errors in Navigation.tsx, test-api/page.tsx, and matches/upload/page.tsx
- Fixed missing useEffect dependency in tournaments/[id]/entry/page.tsx
- Updated eslint config to exclude test-api directory
- All tests now pass linting and build successfully
This commit is contained in:
2026-03-29 21:20:20 -07:00
parent bc99dee421
commit 576dfda619
14 changed files with 60 additions and 50 deletions
+11 -10
View File
@@ -1,5 +1,5 @@
import { describe, it, expect, vi, beforeEach } from 'vitest'
import { render, screen, fireEvent, waitFor } from '@testing-library/react'
import { describe, it, expect, vi, beforeEach, MockedFunction } from 'vitest'
import { render, screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import EditTournamentForm from '@/components/EditTournamentForm'
@@ -18,7 +18,8 @@ vi.mock('next/link', () => ({
}))
// Mock fetch
global.fetch = vi.fn()
const mockFetch = vi.fn()
global.fetch = mockFetch as MockedFunction<typeof global.fetch>
const mockTournament = {
id: 1,
@@ -65,10 +66,10 @@ describe('EditTournamentForm', () => {
it('submits form with updated data', async () => {
const user = userEvent.setup()
;(global.fetch as any).mockResolvedValueOnce({
mockFetch.mockResolvedValueOnce({
ok: true,
json: async () => ({ success: true }),
})
} as Response)
render(<EditTournamentForm tournament={mockTournament} />)
@@ -80,7 +81,7 @@ describe('EditTournamentForm', () => {
await user.click(submitButton)
await waitFor(() => {
expect(global.fetch).toHaveBeenCalledWith(
expect(mockFetch).toHaveBeenCalledWith(
'/api/tournaments/1',
expect.objectContaining({
method: 'PUT',
@@ -92,10 +93,10 @@ describe('EditTournamentForm', () => {
it('shows error message on failed submission', async () => {
const user = userEvent.setup()
;(global.fetch as any).mockResolvedValueOnce({
mockFetch.mockResolvedValueOnce({
ok: false,
json: async () => ({ error: 'Failed to update tournament' }),
})
} as Response)
render(<EditTournamentForm tournament={mockTournament} />)
@@ -109,14 +110,14 @@ describe('EditTournamentForm', () => {
it('disables submit button while loading', async () => {
const user = userEvent.setup()
;(global.fetch as any).mockImplementation(
mockFetch.mockImplementation(
() =>
new Promise((resolve) => {
setTimeout(() => {
resolve({
ok: true,
json: async () => ({ success: true }),
})
} as Response)
}, 100)
})
)
+2 -2
View File
@@ -1,4 +1,4 @@
import { describe, it, expect, vi, beforeEach } from 'vitest'
import { describe, it, expect, vi, beforeEach, MockedFunction } from 'vitest'
import { getSession } from '@/lib/auth-simple'
// Mock next/headers
@@ -10,7 +10,7 @@ vi.mock('next/headers', () => ({
// Mock fetch
const mockFetch = vi.fn()
global.fetch = mockFetch as any
global.fetch = mockFetch as MockedFunction<typeof global.fetch>
describe('getSession', () => {
beforeEach(() => {
+1 -1
View File
@@ -125,7 +125,7 @@ test.describe.serial('Account Lifecycle Acceptance Test', () => {
* Test 3: Delete test account
* Uses the authenticated project (admin)
*/
test('3. Delete test account', async ({ page }) => {
test('3. Delete test account', async () => {
// For now, we'll delete via direct database access
// In a real scenario, this would be done via an admin API endpoint
const user = await prisma.user.findUnique({
+2 -7
View File
@@ -6,14 +6,11 @@
import { test, expect } from '@playwright/test';
import { PrismaClient } from '@prisma/client';
import { scryptAsync } from '@noble/hashes/scrypt.js';
import { hex } from '@better-auth/utils/hex';
import fs from 'fs';
import path from 'path';
const prisma = new PrismaClient();
// Polyfill crypto for Node.js environment
const crypto = globalThis.crypto || require('crypto').webcrypto;
test.describe('Elo Rating Updates', () => {
test.beforeAll(async () => {
// Clean up any existing test data
@@ -285,8 +282,6 @@ ${tournament.id},1,1,${player1.name},${player3.name},10,${player2.name},${player
${tournament.id},2,1,${player1.name},${player3.name},10,${player2.name},${player4.name},5,odds`;
// Upload first match through UI
const fs = require('fs');
const path = require('path');
const tmpFile1 = path.join('/tmp', `elo-test-multi-1-${Date.now()}.csv`);
fs.writeFileSync(tmpFile1, csvContent1);
@@ -141,7 +141,7 @@ test.describe.serial('Epic 1: User Registration', () => {
// If we're still on the registration page, check for error message
const content = await page.content();
expect(content).toContain('error');
} catch (e) {
} catch {
// If redirected successfully, that's fine
console.log('Registration redirected to:', page.url());
}
+2 -2
View File
@@ -53,7 +53,7 @@ export default async function globalSetup(config: FullConfig) {
{ timeout: 10000 }
);
console.log('Sign-up API call successful');
} catch (e) {
} catch {
console.log('Sign-up API call failed or timed out');
}
@@ -97,7 +97,7 @@ export default async function globalSetup(config: FullConfig) {
{ timeout: 10000 }
);
console.log('Admin sign-up API call successful');
} catch (e) {
} catch {
console.log('Admin sign-up API call failed or timed out');
}
-3
View File
@@ -141,9 +141,6 @@ describe('Elo Rating System', () => {
const team1Rating = calculateTeamElo(player1Rating, player2Rating);
const team2Rating = calculateTeamElo(player3Rating, player4Rating);
const team1Expected = calculateExpectedScore(team1Rating, team2Rating);
const team2Expected = calculateExpectedScore(team2Rating, team1Rating);
// Team 1 wins (score = 1, team 2 score = 0)
const team1Change = calculateEloChange(team1Rating, team2Rating, 1, K_FACTOR);
const team2Change = calculateEloChange(team2Rating, team1Rating, 0, K_FACTOR);
+9 -8
View File
@@ -8,9 +8,10 @@ import { describe, test, expect, vi } from 'vitest';
import { hasRole, canManageTournament, canCreateTournaments } from '@/lib/permissions';
import { getSession } from '@/lib/auth-simple';
import { prisma } from '@/lib/prisma';
import type { User } from '@prisma/client';
// Helper to create mock user
const createMockUser = (id: string, email: string, role: string) => ({
const createMockUser = (id: string, email: string, role: string): User => ({
id,
email,
role,
@@ -46,7 +47,7 @@ describe('Permissions', () => {
session: { token: 'test', expiresAt: new Date() }
});
vi.mocked(prisma.user.findUnique).mockResolvedValue(
createMockUser('1', 'test@example.com', 'club_admin') as any
createMockUser('1', 'test@example.com', 'club_admin')
);
const result = await hasRole('tournament_admin');
@@ -59,7 +60,7 @@ describe('Permissions', () => {
session: { token: 'test', expiresAt: new Date() }
});
vi.mocked(prisma.user.findUnique).mockResolvedValue(
createMockUser('1', 'test@example.com', 'player') as any
createMockUser('1', 'test@example.com', 'player')
);
const result = await hasRole('tournament_admin');
@@ -82,7 +83,7 @@ describe('Permissions', () => {
session: { token: 'test', expiresAt: new Date() }
});
vi.mocked(prisma.user.findUnique).mockResolvedValue(
createMockUser('admin-1', 'admin@example.com', 'club_admin') as any
createMockUser('admin-1', 'admin@example.com', 'club_admin')
);
const result = await canManageTournament(999);
@@ -95,7 +96,7 @@ describe('Permissions', () => {
session: { token: 'test', expiresAt: new Date() }
});
vi.mocked(prisma.user.findUnique).mockResolvedValue(
createMockUser('player-1', 'player@example.com', 'player') as any
createMockUser('player-1', 'player@example.com', 'player')
);
const result = await canManageTournament(999);
@@ -111,7 +112,7 @@ describe('Permissions', () => {
session: { token: 'test', expiresAt: new Date() }
});
vi.mocked(prisma.user.findUnique).mockResolvedValue(
createMockUser('admin-1', 'admin@example.com', 'tournament_admin') as any
createMockUser('admin-1', 'admin@example.com', 'tournament_admin')
);
const result = await canCreateTournaments();
@@ -124,7 +125,7 @@ describe('Permissions', () => {
session: { token: 'test', expiresAt: new Date() }
});
vi.mocked(prisma.user.findUnique).mockResolvedValue(
createMockUser('admin-1', 'admin@example.com', 'club_admin') as any
createMockUser('admin-1', 'admin@example.com', 'club_admin')
);
const result = await canCreateTournaments();
@@ -137,7 +138,7 @@ describe('Permissions', () => {
session: { token: 'test', expiresAt: new Date() }
});
vi.mocked(prisma.user.findUnique).mockResolvedValue(
createMockUser('player-1', 'player@example.com', 'player') as any
createMockUser('player-1', 'player@example.com', 'player')
);
const result = await canCreateTournaments();